kubeadm should ignore cgroup driver check on Windows node

[pacoxu]

What type of PR is this?
/kind bug
/sig windows
/sig cluster-lifecycle
/area kubeadm

What this PR does / why we need it:

kubeadm doesn't do anything about cgroup drivers on Windows because cgroups don't exist on Windows.
ideally the kubelet checks about this should be skipped entirely in dockershim for non-Linux.

Which issue(s) this PR fixes:

Fixes #97759

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[neolit123]

/remove-area kubeadm
/remove-sig cluster-lifecycle

[neolit123]

i think it should be:

if runtime.GOOS == "linux" {
	// NOTE: cgroup driver is only detectable in docker 1.11+
	cgroupDriver := defaultCgroupDriver
	dockerInfo, err := ds.client.Info()
	klog.Infof("Docker Info: %+v", dockerInfo)
	if err != nil {
		klog.Errorf("Failed to execute Info() call to the Docker client: %v", err)
		klog.Warningf("Falling back to use the default driver: %q", cgroupDriver)
	} else if len(dockerInfo.CgroupDriver) == 0 {
		klog.Warningf("No cgroup driver is set in Docker")
		klog.Warningf("Falling back to use the default driver: %q", cgroupDriver)
	} else {
		cgroupDriver = dockerInfo.CgroupDriver
	}
	if len(kubeCgroupDriver) != 0 && kubeCgroupDriver != cgroupDriver {
		return nil, fmt.Errorf("misconfiguration: kubelet cgroup driver: %q is different from docker cgroup driver: %q", kubeCgroupDriver, cgroupDriver)
	}
	klog.Infof("Setting cgroupDriver to %s", cgroupDriver)
	ds.cgroupDriver = cgroupDriver
}

if dockershim complains about an empty ds.cgroupDriver on Windows it should be fixed too.

[neolit123]

this looks right to me. SIG Node owners can approve.
/lgtm

[pacoxu]

@neolit123 updated.

[neolit123]

@kubernetes/sig-windows-bugs

[hasheddan]

/priority important-soon

[pacoxu]

/triage accepted

[ehashman]

ping @derekwaynecarr @ehashman for approval

I cannot approve but I'll move it on the board 😄

[pacoxu]

thanks @ehashman

[marosset]

@derekwaynecarr @mrunalp Can one of you take a look for sig-node approval? Thanks!

[mrunalp]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

we need to backport this to the support skew:
.18, .19, .20

the kubeadm e2e test jobs for Windows are failing because of it:
kubernetes-sigs/sig-windows-tools#138

@pacoxu would you be able to send the cherry picks?

[pacoxu]

@neolit123 OK, I will send the cherry picks.

[neolit123]

thanks!

[neolit123]

@pacoxu please change the release note to have "kubelet" instead of "kubeadm" (as the change is in the kubelet).
this applies to the cherry pick PRs too.

[pacoxu]

@neolit123 all are updated now. 🤝