Skip to content

Generated new documentation.md for kubernetes metrics reference #120369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

Generated new documentation.md for kubernetes metrics reference #120369

merged 1 commit into from
Sep 6, 2023

Conversation

Gauravpadam
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR is associated with #120350, Which aims to change the generator codes for the kubernetes metrics reference

Special notes for your reviewer:

A separate PR for the updated documentation.md

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Gauravpadam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 1, 2023
@Gauravpadam Gauravpadam mentioned this pull request Sep 1, 2023
Merged
@Gauravpadam
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 2, 2023
@Gauravpadam
Copy link
Member Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 3, 2023
@logicalhan
Copy link
Member

squash and i'll happily approve :)

@Gauravpadam Gauravpadam force-pushed the update-generated-html branch from 99e0f6a to ebb62b2 Compare September 5, 2023 18:13
@Gauravpadam
Copy link
Member Author

@logicalhan Done, I've squashed the commits

logicalhan
logicalhan approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4c16580b3b7bead771aae710dfbc043f762bb54

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gauravpadam, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@Gauravpadam
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@Gauravpadam: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@Gauravpadam: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gauravpadam
Copy link
Member Author

@logicalhan Can you please have a look?

@Gauravpadam
Commits merged
2144852 
Some label fixes

Wrapper class is now metric

merged commits
@Gauravpadam Gauravpadam force-pushed the update-generated-html branch from ebb62b2 to 2144852 Compare September 5, 2023 20:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
logicalhan
logicalhan reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb56ba0f4aaec0276975a6dd687ab6b4f55e2f62

@Gauravpadam
Copy link
Member Author

@logicalhan Can we retest the failing one? I'll probably require an ok-to-test to do so

@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2023
@Gauravpadam
Copy link
Member Author

@pacoxu Thanks, And @logicalhan Thanks for being so patient with the PR, Really appreciate that 😃

@k8s-ci-robot k8s-ci-robot merged commit 04292dd into kubernetes:master Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 6, 2023
@Gauravpadam Gauravpadam mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly Awaiting requested review from pohly

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.29

Development

Successfully merging this pull request may close these issues.

4 participants

@Gauravpadam @k8s-ci-robot @logicalhan @pacoxu