Skip to content

Conversation

thockin
Copy link
Member

@thockin thockin commented Oct 4, 2023

This is not used internally, but is needed by external projects which use the old script, making this sort of a regression.

Fixes #120803
cc @ary1992

/kind bug
/kind regression

NONE

This is not used internally, but is needed by external projects which
use the old script, making this sort of a regression.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 4, 2023
@thockin
Copy link
Member Author

thockin commented Oct 4, 2023

/retest

@cici37
Copy link
Contributor

cici37 commented Oct 5, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2023
@ary1992
Copy link

ary1992 commented Oct 5, 2023

Thank you for the PR.

# --boilerplate <string = path_to_kube_codegen_boilerplate>
# An optional override for the header file to insert into generated files.
#
# --extra-peer-dir <string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly, but this is so close to the actual internal flag it is plumbing to... should we just use --extra-peer-dirs here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that on purpose. The tool's --extra-peer-dirs takes --extra-peer-dirs="foo,bar,bat" or --extra-peer-dirs=foo --extra-peer-dirs=bar --extra-peer-dirs=bat (which I don't love but oh well). This script does NOT parse the comma-delimited version

@liggitt
Copy link
Member

liggitt commented Oct 18, 2023

/lgtm
/approve
/hold in case you want to tweak the name for https://github.com/kubernetes/kubernetes/pull/120994/files#r1362991365

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7720f00fd9d541fdf432de374cd2807aca618e40

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1c2b002 into kubernetes:master Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 19, 2023
@thockin thockin deleted the kube_codegen_extra_peer_dirs branch March 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code-generator] --extra-peer-dirs flag is not supported by new kube-codegen.sh script

6 participants