Skip to content

Update snapshot CRDs to v1 in cluster addons #129488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2025
Merged

Update snapshot CRDs to v1 in cluster addons #129488

merged 2 commits into from
Jan 13, 2025

Conversation

Madhu-1
Copy link
Contributor

@Madhu-1 Madhu-1 commented Jan 6, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the snapshot CRD's to v1 in the cluster addons to keep it sync with the external-snapshotter

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 6, 2025
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 6, 2025

/sig storage

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2025
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 6, 2025

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 6, 2025
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 6, 2025

/assign @xing-yang @jsafrane

@jsafrane
Copy link
Member

jsafrane commented Jan 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2025
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 7, 2025

/test pull-kubernetes-e2e-gce-storage-snapshot

carlory
carlory reviewed Jan 8, 2025
View reviewed changes
cluster/addons/volumesnapshots/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml
kind: CustomResourceDefinition
metadata:
labels:
addonmanager.kubernetes.io/mode: Reconcile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove it. Addons with label addonmanager.kubernetes.io/mode=Reconcile will be periodically
reconciled by addonmanager.

carlory
carlory reviewed Jan 8, 2025
View reviewed changes
cluster/addons/volumesnapshots/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml
kind: CustomResourceDefinition
metadata:
labels:
addonmanager.kubernetes.io/mode: Reconcile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

carlory
carlory reviewed Jan 8, 2025
View reviewed changes
cluster/addons/volumesnapshots/crd/snapshot.storage.k8s.io_volumesnapshots.yaml
kind: CustomResourceDefinition
metadata:
labels:
addonmanager.kubernetes.io/mode: Reconcile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 9, 2025

/test pull-kubernetes-e2e-gce-storage-snapshot

Madhu-1 added 2 commits January 9, 2025 15:24
@Madhu-1
update snapshot CRDs to v1 in cluster addons
c6f19d3 
Updating the snapshot CRD's to v1 inthe cluster
addons to keep it sync with the external-snapshotter
@Madhu-1
remove workaround for vsg testing
8d79998 
remove the extra kubectl apply for
the volume snapshot CRD in vgs tests

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 9, 2025
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 9, 2025

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 9, 2025

/test pull-kubernetes-e2e-gce-storage-snapshot

@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jan 10, 2025

@xing @jsafrane both the snapshot and volumegroupsnapshot test passed, can you please take a look at this one?

@Madhu-1 Madhu-1 requested a review from carlory January 10, 2025 08:55
@carlory
Copy link
Member

carlory commented Jan 10, 2025

/lgtm
/assign @jsafrane
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3b267fb5be147943d6abb2c5a015b7a83d09667

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8a5cf7b into kubernetes:master Jan 13, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 13, 2025
@tot0089896-ux

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@carlory carlory Awaiting requested review from carlory

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
6 participants
@Madhu-1 @k8s-ci-robot @jsafrane @carlory @xing-yang @tot0089896-ux