-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Simplify shouldDelegateList #130752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify shouldDelegateList #130752
Conversation
When ResourceVersionMatch is set to NotOlderThan, there is no need to handle continue or resourceVersion="". The validation in apimachinery will not pass and return: * "resourceVersionMatch is forbidden when continue is provided" * "resourceVersionMatch is forbidden unless resourceVersion is provided"
/lgtm |
LGTM label has been added. Git tree hash: 73ca48d74c739eeb84aa2a5febfe222905adc7fd
|
/retest |
@serathius: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, sins921, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When ResourceVersionMatch is set to NotOlderThan, there is no need to handle continue or resourceVersion="". The validation in apimachinery will not pass and return:
kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/internalversion/validation/validation.go
Lines 33 to 39 in fb98a59
What type of PR is this?
/kind cleanup
/sig api-machinery
/sig api-machinery
/triage accepted
/assign @wojtek-t @jpbetz
/cc @liggitt