Skip to content

Make LinuxOnly tag on tests strongly typed #134413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make LinuxOnly tag on tests strongly typed #134413

wants to merge 1 commit into from

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Making tag strongly typed. As a follow up we should discuss more on how to improve it.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 4, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 4, 2025
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/network-policy Issues or PRs related to Network Policy subproject area/test sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign tallclair, thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 4, 2025
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind 941abea link true /test pull-kubernetes-e2e-kind
pull-kubernetes-conformance-kind-ga-only-parallel 941abea link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-node-e2e-containerd 941abea link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-kind-nftables 941abea link false /test pull-kubernetes-e2e-kind-nftables
pull-kubernetes-unit 941abea link true /test pull-kubernetes-unit
pull-kubernetes-e2e-gce-storage-slow 941abea link false /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-network-policies 941abea link false /test pull-kubernetes-e2e-gce-network-policies
pull-kubernetes-e2e-gce 941abea link true /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-csi-serial 941abea link false /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-storage-kind-disruptive 941abea link false /test pull-kubernetes-e2e-storage-kind-disruptive
pull-kubernetes-e2e-gce-storage-snapshot 941abea link false /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gci-gce-ingress 941abea link false /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-e2e-storage-kind-vac 941abea link false /test pull-kubernetes-e2e-storage-kind-vac
pull-kubernetes-verify 941abea link true /test pull-kubernetes-verify
pull-kubernetes-integration 941abea link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aojea
Copy link
Member

aojea commented Oct 4, 2025 •
edited
Loading

@SergeyKanzhelev

_output/bin/e2e.test -list-labels
Unknown Decorator
k8s.io/kubernetes/test/e2e/common/node/downwardapi.go:142
[It] node was passed an unknown decorator:
'framework.label{parts:[]string{"LinuxOnly"}, explanation:"If you see this as
part of an 'Unknown Decorator' error from Ginkgo, then you need to replace the
ginkgo.It/Context/Describe call with the corresponding
framework.It/Context/Describe or (if available) f.It/Context/Describe.",
alphaBetaLevel:"", offByDefault:false}'

Learn more at: http://onsi.github.io/ginkgo/#node-decorators-overview

cc: @pohly

@enj enj moved this to Needs Triage in SIG Auth Oct 4, 2025
pohly
pohly reviewed Oct 4, 2025
View reviewed changes
test/e2e/framework/ginkgowrapper.go

// WithLinuxOnly specifies that a certain test or group of tests must only run
// on Linux nodes. The return value must be passed as additional argument to
// [framework.It], [framework.Describe], [framework.Context].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more what "run on Linux nodes" means? Tests don't run on nodes. They create pods, which then may need Linux nodes. Is that what is meant here?

What about clusters with a mixture of Linux and Windows nodes. Are jobs with such a setup meant to filter out "LinuxOnly" tests?

This PR is an opportunity to clarify how to use this tag. Let's use this opportunity...

@ibihim ibihim moved this from Needs Triage to !SIG Auth in SIG Auth Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@HirazawaUi HirazawaUi Awaiting requested review from HirazawaUi

1 more reviewer

@pohly pohly pohly left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/network-policy Issues or PRs related to Network Policy subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Status: !SIG Auth
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeyKanzhelev @k8s-ci-robot @aojea @pohly