-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Add DV list keys on ResourceClaimStatus.Devices #134443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
eecb670
to
d47da99
Compare
d47da99
to
a3cdea6
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lalitc375 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a3cdea6
to
1c20dfc
Compare
1c20dfc
to
9c01dcb
Compare
9c01dcb
to
b7b668d
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables the use of pointer fields as keys in
listType=map
lists in the Kubernetes API. Currently, fields of pointer types cannot be used as keys for lists withlistType=map
semantics. This PR lifts that restriction by updating the code generator and validation logic to correctly handle pointer types inlistMapKey
s.The key changes are:
validation-gen
code generator is updated to handle pointer types inlistMapKey
by checking fornil
and dereferencing pointers before comparison.ResourceClaimStatus.Devices
field is updated to uselistType=map
with a composite key that includes theshareID
field, which is a pointer type.listMapKey
s.This change provides more flexibility in defining API types by allowing the use of pointer fields as keys in maps, which is useful in scenarios where a key field can be optional.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: