Fixing logic to generate ExternalHost in genericapiserver #26796
Conversation
nikhiljindal
added
the
sig/api-machinery
|
This is a behavioral change between 1.2 and 1.3, right? re release notes |
|
cc @kubernetes/sig-api-machinery @smarterclayton @liggitt @deads2k |
k8s-github-robot
added
size/XS
|
GCE e2e build/test passed for commit 1b6e8f9. |
nikhiljindal
added
release-note-action-required
|
Updated the release note label |
| @@ -303,7 +303,7 @@ func setDefaults(c *Config) { | |||
| if len(c.ExternalHost) == 0 && c.PublicAddress != nil { | |||
| hostAndPort := c.PublicAddress.String() | |||
| if c.ReadWritePort != 0 { | |||
There was a problem hiding this comment.
This if statement will always trigger, since ReadWritePort is set on L295.
|
This looks correct based on the documentation for the fields. |
lavalamp
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 1b6e8f9. |
|
Automatic merge from submit-queue |
|
@nikhiljindal Does this PR require action by the user when upgrading from 1.2.x to 1.3.0? (Think about non-developer users.) If so, please edit your first comment to have a release-note block, like in #28132. If it is just an optional feature, please change the label to just release-note. If it is not a complete feature by itself, then apply "release-note-none" label instead. |
@ncdc pointed it out (https://kubernetes.slack.com/archives/sig-api-machinery/p1464974528000139) that lines 305 and 306 dont match. We should be using ReadWritePort instead of ServiceReadWritePort in line 306.
#20626 seems to be the culprit PR.