Automated cherry pick of #64598: Remove optimization from getWork in #65640
Conversation
This change simplifies the code in plugin/pkg/admission/resourcequota/controller.go by removing the optimization in getWork that required the caller to NOT call completeWork if getWork returns the empty list of work. BTW, the caller was not obeying that requirement; now the caller's behavior (which is unchanged) is right. Fixes kubernetes#63608
|
@MikeSpreitzer: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #64598. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
|
@MikeSpreitzer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
@MikeSpreitzer Can you add a release note to #64598, so that users know this was fixed in patch release? |
MaciekPytel
added
cherry-pick-approved
|
@MaciekPytel : how do I add a release-specific release note? Wouldn't it go here rather than in the base PR? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@MikeSpreitzer AFAIK you can't add a release-specific release note. The same one will be used for every release base commit is cherry-picked into. Tooling that generates release notes takes them from parent PRs and ignores whatever is set on cherry-pick PR. The preference is for anything that goes into patch release to have a release note, unless it's something with no impact on users (like fixing a bug in test, etc). |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Cherry pick of #64598 on release-1.10.
#64598: Remove optimization from getWork in