Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cAdvisor web UI port has been deprecated since v1.10. This patch updates the description about it. #11426

Merged
merged 3 commits into from
Dec 17, 2018
Merged

cAdvisor web UI port has been deprecated since v1.10. This patch updates the description about it. #11426

merged 3 commits into from
Dec 17, 2018

Conversation

WanLinghao
Copy link
Contributor

@WanLinghao WanLinghao commented Nov 30, 2018 •
edited
Loading

cAdvisor web UI port has been deprecated since v1.10. This patch updates the description about it.

ref:kubernetes/kubernetes#65707

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 30, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 62772c7

https://deploy-preview-11426--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 30, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0308221

https://deploy-preview-11426--kubernetes-io-master-staging.netlify.com

Bradamant3
Bradamant3 previously requested changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@Bradamant3 Bradamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version support isn't clear in the original. Copyedits make the issue more obvious. Please clarify!

content/en/docs/tasks/debug-application-cluster/resource-usage-monitoring.md Outdated

![cAdvisor](/images/docs/cadvisor.png)

In version 1.10 and later, the Advisor module does not provide this UI. Instead, you can [run cAdvisor as DaemonSet](https://github.com/google/cadvisor/tree/master/deploy/kubernetes).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also line 55. The original is unclear (before 1.10 and after 1.10 -- but what about IN 1.10?). Are lines 55 and 59 now correct? They are clearer, but the original could also have meant that the UI was available in 1.10 but not in 1.11. Please specify either in new commit or in comment. Thanks!

@WanLinghao
Copy link
Contributor Author

@Bradamant3 What do you think this time

@WanLinghao
Copy link
Contributor Author

@Bradamant3 friendly ping

@WanLinghao
Copy link
Contributor Author

@Bradamant3 PTAL

@tengqm tengqm dismissed Bradamant3’s stale review December 17, 2018 05:25

Comments addressed

@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3ccbb12 into kubernetes:master Dec 17, 2018
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
@WanLinghao @kychool
cAdvisor web UI port has been deprecated since v1.10. This patch upda…
80d6cb0 
…tes the description about it. (kubernetes#11426)

* cAdvisor web UI port has been deprecated since v1.10. This patch update the description about it.

* Update resource-usage-monitoring.md

* Update resource-usage-monitoring.md
kychool pushed a commit to kychool/website that referenced this pull request Dec 26, 2018
@WanLinghao @kychool
cAdvisor web UI port has been deprecated since v1.10. This patch upda…
463c06b 
…tes the description about it. (kubernetes#11426)

* cAdvisor web UI port has been deprecated since v1.10. This patch update the description about it.

* Update resource-usage-monitoring.md

* Update resource-usage-monitoring.md
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@WanLinghao
cAdvisor web UI port has been deprecated since v1.10. This patch upda…
8c2da7c 
…tes the description about it. (kubernetes#11426)

* cAdvisor web UI port has been deprecated since v1.10. This patch update the description about it.

* Update resource-usage-monitoring.md

* Update resource-usage-monitoring.md
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@WanLinghao
cAdvisor web UI port has been deprecated since v1.10. This patch upda…
a2c00d3 
…tes the description about it. (kubernetes#11426)

* cAdvisor web UI port has been deprecated since v1.10. This patch update the description about it.

* Update resource-usage-monitoring.md

* Update resource-usage-monitoring.md
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
@WanLinghao @bsalamat
cAdvisor web UI port has been deprecated since v1.10. This patch upda…
87912e9 
…tes the description about it. (kubernetes#11426)

* cAdvisor web UI port has been deprecated since v1.10. This patch update the description about it.

* Update resource-usage-monitoring.md

* Update resource-usage-monitoring.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bradamant3 Bradamant3 Bradamant3 left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WanLinghao @k8sio-netlify-preview-bot @tengqm @k8s-ci-robot @Bradamant3