Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #66165: Compare stateful set updates semantically #66167

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Automated cherry pick of #66165: Compare stateful set updates semantically #66167

merged 1 commit into from
Jul 18, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 13, 2018 •
edited
Loading

Cherry pick of #66165 on release-1.10.

#66165: Compare stateful set updates semantically

fixes a validation error that could prevent updates to StatefulSet objects containing non-normalized resource requests

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 13, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2018
@k8s-ci-robot k8s-ci-robot requested review from dims and pmorie July 13, 2018 17:37
@liggitt
Copy link
Member Author

liggitt commented Jul 13, 2018 •
edited
Loading

/sig apps
/kind bug
/priority important-soon
/milestone v1.10
/assign @MaciekPytel
@kubernetes/sig-apps-pr-reviews

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 13, 2018
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 13, 2018
@liggitt liggitt modified the milestones: v1.11, v1.10 Jul 13, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 17, 2018
@liggitt
Copy link
Member Author

liggitt commented Jul 17, 2018

/assign @tnozicka

tnozicka
tnozicka approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@MaciekPytel @liggitt @tnozicka @kubernetes/sig-apps-misc

Important: This pull request was missing the status/approved-for-milestone label for more than 4 days.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.10 milestone Jul 17, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 986ed67 into kubernetes:release-1.10 Jul 18, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#66165-upstream-release-1.10 branch April 22, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@dims dims Awaiting requested review from dims

@pmorie pmorie Awaiting requested review from pmorie

Assignees

@MaciekPytel MaciekPytel

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-ci-robot @fejta-bot @k8s-github-robot @tnozicka @MaciekPytel