Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: Pull sidecar and dnsmasq-nanny images when using kube-dns #66499
What this PR does / why we need it:
It appears that sidecar and dnsmasq-nanny images are now required for
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I was a bit baffled by this too, but it is true. Tried it with a clean setup in a VM with Kubernetes 1.11.1 and it indeed fetched the sidecar and dnsmasq-nanny images and started them up:
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
referenced this pull request
Jul 24, 2018
Humm sorry I'm missing some context here. From kube-dns point of view these two images are always required since long ago (1.5ish?). This feels like some sort of pre-loading mechanism in kubeadm, does it work on earlier k8s versions?