Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #61549 upstream release 1.10 #69049

Conversation

jingxu97
Copy link
Contributor

#61549 is a bug fix for issue #61248

Kubernetes Submit Queue and others added 30 commits June 1, 2018 04:52
…pick-of-#64383-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#64383: fix azure file size grow issue

Cherry pick of kubernetes#64383 on release-1.10.

kubernetes#64383: fix azure file size grow issue
…f-#62505-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#62505: update godeps to use latest pflag

Cherry pick of kubernetes#62505 on release-1.10.

kubernetes#62505: update godeps to use latest pflag

```release-note
Show help for deprecated Kubelet flags
```
…ck-of-#63303-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#63303: Return attach error to A/D controller.

Cherry pick of kubernetes#63303 on release-1.10.

kubernetes#63303: Return attach error to A/D controller.

```release-note
Fixed error reporting of CSI volumes attachment.
```
Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
…pick-of-#62670-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#62670: Fix kubelet flags.

Cherry pick of kubernetes#62670 on release-1.10.

kubernetes#62670: Fix kubelet flags.
…ck-of-#64026-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#64026: Add SELinux support to CSI

Cherry pick of kubernetes#64026 on release-1.10.

kubernetes#64026: Add GetSELinuxSupport to mounter.

```release-note
Fixed SELinux relabeling of CSI volumes.
```
…pick-of-#62753-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#62753: Fix extra-log flag for node e2e.

Cherry pick of kubernetes#62753 on release-1.10.

kubernetes#62753: Fix extra-log flag for node e2e.
fix comments

fix comments

fix comments

fix comments
…-of-#63770-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#63770: Implement Skip() for ingress upgrade test

Cherry pick of kubernetes#63770 on release-1.10.

kubernetes#63770: Implement Skip() for ingress upgrade test

```release-note
NONE
```
…InUseProtection-downgrade-issue-cherry-pick-into-K8s-1.10

Automatic merge from submit-queue.

cherry-pick into K8s 1.10: Always Start pvc-protection-controller and pv-protection-controller

**What this PR does / why we need it**:
StorageObjectInUseProtection feature is enabled by default in K8s 1.10+. Assume K8s cluster is used with this feature enabled, i.e. finalizers are added to all PVs and PVCs. In case the K8s cluster admin disables the StorageObjectInUseProtection feature and a user deletes a PVC that is not in active use by a pod then the PVC is not removed from the system because of the finalizer. Therefore, the user will have to remove the finalizer manually in order to have the PVC removed from the system. Note: deleted PVs won't be removed from the system also because of finalizers.

This problem was fixed in [K8s 1.9.6](https://github.com/kubernetes/kubernetes/releases/tag/v1.9.6) in PR kubernetes#61370
This problem is also fixed in K8s 1.11+ in PR kubernetes#61324
However, this problem is not fixed in K8s 1.10, that's why I've cherry-picked the PR kubernetes#61324 and proposing to merge it into K8s 1.10.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes 
N/A

Related issue: kubernetes#60764

**Special notes for your reviewer**:

**Release note**:

```release-note
In case StorageObjectInUse feature is disabled and Persistent Volume (PV) or Persistent Volume Claim (PVC) contains a finalizer and the PV or PVC is deleted it is not automatically removed from the system. Now, it is automatically removed.
```
…rry-pick-of-#64519-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of kubernetes#64519: CSI fix for gRPC conn leak, test updates

Cherry pick of kubernetes#64519 on release-1.10.

kubernetes#64519: CSI fix for gRPC conn leak, test updates

```release-note
Fixed CSI gRPC connection leak during volume operations.
```
…-of-#64351-upstream-release-1.10

Automatic merge from submit-queue.

[1.10] Automated cherry pick of kubernetes#64351: Only mount subpath as readonly if specified in volumeMount

Automated cherry pick of kubernetes#64351: Only mount subpath as readonly if specified in volumeMount

**Release note**:

```release-note
Fixes issue for readOnly subpath mounts for SELinux systems and when the volume mountPath already existed in the container image.
```
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
1.10 e2e tests get run against 1.11.0+ masters during upgrade tests.
This fails as Sysctl moved from annotations to fields, so we should
check the version and avoid running these tests.
@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

@jingxu97: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubeadm area/kubectl area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 25, 2018
@jingxu97 jingxu97 closed this Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

@jingxu97: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-build 7846de6 link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test 7846de6 link /test pull-kubernetes-bazel-test
pull-kubernetes-cross 7846de6 link /test pull-kubernetes-cross
pull-kubernetes-local-e2e-containerized 7846de6 link /test pull-kubernetes-local-e2e-containerized
pull-kubernetes-local-e2e 7846de6 link /test pull-kubernetes-local-e2e
pull-kubernetes-e2e-kops-aws 7846de6 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce 7846de6 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gke 7846de6 link /test pull-kubernetes-e2e-gke
pull-kubernetes-e2e-gce-device-plugin-gpu 7846de6 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-node-e2e 7846de6 link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce-100-performance 7846de6 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 7846de6 link /test pull-kubernetes-typecheck
pull-kubernetes-integration 7846de6 link /test pull-kubernetes-integration
pull-kubernetes-kubemark-e2e-gce-big 7846de6 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-verify 7846de6 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver area/kubeadm area/kubectl area/kubelet do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet