Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSINodeInfo and CSIDriver Core APIs #73883

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@xing-yang
Copy link
Contributor

xing-yang commented Feb 10, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as v1beta1 core storage APIs.

Which issue(s) this PR fixes:

Fixes #
kubernetes/enhancements#770
kubernetes/enhancements#603

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Transition CSINodeInfo and CSIDriver to in-tree core storage v1beta1 APIs.
The support for `_` in the CSI driver name will be dropped as the CSI Spec does not allow that. 
@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 10, 2019

/sig storage

@xing-yang xing-yang force-pushed the xing-yang:csi_crd branch from b1a552c to 7c2b1eb Feb 10, 2019

@xing-yang xing-yang force-pushed the xing-yang:csi_crd branch from 7c2b1eb to e26da96 Feb 10, 2019

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 10, 2019

/test pull-kubernetes-verify

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 11, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Feb 11, 2019

@xing-yang could you seperate the PR out into two/three commits? One for API changes, one for generated code, one for any additional changes (if there are any).

This would make it much easier to review. Thanks!

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 11, 2019

@xing-yang could you seperate the PR out into two/three commits? One for API changes, one for generated code, one for any additional changes (if there are any).

This would make it much easier to review. Thanks!

Will do.

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

@xing-yang xing-yang force-pushed the xing-yang:csi_crd branch from dffd5a7 to eed7b35 Feb 28, 2019

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 28, 2019

Rebased.

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

@xing-yang xing-yang force-pushed the xing-yang:csi_crd branch 2 times, most recently from 69cac92 to aa5150e Feb 28, 2019

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 28, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883
@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Feb 28, 2019

/test pull-kubernetes-e2e-gce-100-performance

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Feb 28, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883
@thockin

This comment has been minimized.

Copy link
Member

thockin commented Mar 1, 2019

I'll shift any further comments to #74283

xing-yang added some commits Feb 8, 2019

Make CSINodeInfo and CSIDriver Core APIs
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.

@xing-yang xing-yang force-pushed the xing-yang:csi_crd branch from aa5150e to 743d3a2 Mar 2, 2019

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Mar 2, 2019

Rebased.

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 2, 2019

WIP: CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 3, 2019

CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883
@bertinatto

This comment has been minimized.

Copy link
Member

bertinatto commented Mar 4, 2019

I'm not super familiar with core APIs, but I reviewed this PR and it LGTM.

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 4, 2019

/retest

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 5, 2019

CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

@k8s-ci-robot k8s-ci-robot merged commit 743d3a2 into kubernetes:master Mar 5, 2019

16 of 17 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation xing-yang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 5, 2019

CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883

@liggitt liggitt removed this from In progress in API Reviews Mar 6, 2019

xing-yang added a commit to xing-yang/kubernetes that referenced this pull request Mar 7, 2019

CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
kubernetes#73883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.