Revert "fix shellcheck failures of hack/verify-no-vendor-cycles.sh" #77841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e25e5a6.
k8s-ci-robot
added
size/S
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
|
/cc @fejta @davidz627 |
This was referenced May 13, 2019
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
k8s-ci-robot
added
sig/testing
|
lol amazing. Thanks for the fix :) |
BenTheElder
reviewed
May 13, 2019
| staging_repos=() | ||
| while IFS= read -r repo; do | ||
| staging_repos+=( "${repo}" ) | ||
| done < <(ls "${KUBE_ROOT}/staging/src/k8s.io/") |
There was a problem hiding this comment.
for the future: this should be using find instead of ls
| echo "Package ${i} has a cyclic dependency on staging repository packages: ${deps_on_staging}" | ||
| failed=true | ||
| fi | ||
| done < <(find vendor/ -type d) |
There was a problem hiding this comment.
this should be using -print0
There was a problem hiding this comment.
|
|
||
| failed=false | ||
| while IFS= read -r -d '' i; do | ||
| deps=$(go list -f '{{range .Deps}}{{.}}{{"\n"}}{{end}}' ./"$i" 2> /dev/null || echo "") |
There was a problem hiding this comment.
should be quoting the whole string
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e25e5a6.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
#77055 made changes that rendered the
verify-no-vendor-cycles.shcheck ineffective (it passed immediately on #77837 which introduced vendor cycles)Does this PR introduce a user-facing change?: