Skip to content

Move pkg/kubectl/cmd/util and subdirs to staging #80701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Move pkg/kubectl/cmd/util and subdirs to staging #80701

merged 1 commit into from
Jul 29, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jul 29, 2019

/kind cleanup
/sig cli
/area kubectl
/area code-organization
/priority important-soon

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubectl area/code-organization Issues or PRs related to kubernetes code organization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/test sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 29, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/test pull-kubernetes-integration

@seans3 seans3 force-pushed the move-cmdutil-staging branch from 8dd65de to 7b1c753 Compare July 29, 2019 06:29
@dims
Copy link
Member

dims commented Jul 29, 2019

/approve

@dims
Copy link
Member

dims commented Jul 29, 2019

/retest

@dims
Copy link
Member

dims commented Jul 29, 2019

/assign @apelisse

@seans3 seans3 force-pushed the move-cmdutil-staging branch from 7b1c753 to 7ee16ae Compare July 29, 2019 18:55
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@seans3 seans3 force-pushed the move-cmdutil-staging branch from 7ee16ae to 6c96a05 Compare July 29, 2019 20:09
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/test pull-kubernetes-integration

1 similar comment
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/test pull-kubernetes-integration

@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/assign @liggitt

The following modified files in this PR are "outside" of kubectl, requiring extra approvals:

cmd/clicheck/check_cli_conventions.go
test/integration/apiserver/print_test.go
translations/extract.py
vendor/modules.txt
hack/.golint_failures

@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2019
@liggitt
Copy link
Member

liggitt commented Jul 29, 2019

/approve

@liggitt
Copy link
Member

liggitt commented Jul 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1871f75 into kubernetes:master Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 29, 2019
@seans3 seans3 deleted the move-cmdutil-staging branch August 21, 2019 21:51
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#80701 from seans3/move-cmdutil-staging
8abe6dc 
Move pkg/kubectl/cmd/util and subdirs to staging

Kubernetes-commit: 1871f75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@dims dims Awaiting requested review from dims

Assignees

@liggitt liggitt

@apelisse apelisse

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

5 participants

@seans3 @dims @liggitt @k8s-ci-robot @apelisse