Skip to content

Disable tracking manged fields on scale sub-resource #82045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Disable tracking manged fields on scale sub-resource #82045

merged 1 commit into from
Aug 30, 2019

Conversation

apelisse
Copy link
Member

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Tracking ownership of fields changed by "scale" sub-resource just doesn't work today.
Let's remove it for CRDs and fix it later.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2019
@apelisse
Copy link
Member Author

/cc @lavalamp @jennybuckley

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
@k8s-ci-robot k8s-ci-robot requested review from deads2k and sttts August 27, 2019 22:21
lavalamp
lavalamp reviewed Aug 27, 2019
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an issue and a TODO referencing the issue, otherwise it'll be very mysterious to future readers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, doing now

@apelisse apelisse force-pushed the remove-crd-scale-bug branch from c73bebd to 6652091 Compare August 27, 2019 22:37
@lavalamp
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Aug 28, 2019 •
edited
Loading

Tracking ownership of fields changed by "scale" sub-resource just doesn't work today.
Let's remove it for CRDs and fix it later.

isn't divergent behavior of apply for server-side apply for CRDs and built-in resources problematic?

@apelisse
Copy link
Member Author

isn't divergent behavior of apply for server-side apply for CRDs and built-in resources problematic?

I agree it would be problem. But because of how things are wired, everything will be equally broken after this PR :-)

@liggitt liggitt added this to the v1.16 milestone Aug 29, 2019
@liggitt
Copy link
Member

liggitt commented Aug 29, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 29, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8019ebf into kubernetes:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@lavalamp lavalamp lavalamp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lavalamp lavalamp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

5 participants

@apelisse @lavalamp @k8s-ci-robot @fejta-bot @liggitt