Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup FailureReason in scheduler - part 1 #86492

Closed

Conversation

@Huang-Wei
Copy link
Member

Huang-Wei commented Dec 20, 2019

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

Cleanup the usage of FailureReason in scheduler codebase. Now plugin returns framework.Status instead of []FailureReason.

There are still external usage of FailureReason (e.g., kubelet, daemonset controller), that will be cleaned up in the next PR, and now temporarily, some private functions (e.g., podFitsResources) have to be there to serve both external components and scheduler plugins.

Which issue(s) this PR fixes:

Part of #86353

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/cc @ahg-g

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Plugin returns 'framework.Status' instead of '[]FailureReason'
@Huang-Wei Huang-Wei force-pushed the Huang-Wei:cleanup-FailureReason-1 branch from efbf796 to 3cd6276 Dec 20, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 20, 2019

@Huang-Wei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify 3cd6276 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

Huang-Wei commented Dec 20, 2019

Per offline discussion with @ahg-g, we prefer to remove FailureReason in each plugin gradually (along with its own migration PR). So closing this in favor of #86498.

@Huang-Wei Huang-Wei closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.