Skip to content

Support AlwaysCheckAllPredicates in the scheduler framework. #86496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2019
Merged

Support AlwaysCheckAllPredicates in the scheduler framework. #86496

merged 1 commit into from
Dec 23, 2019

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Dec 20, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds support for AlwaysCheckAllPredicates flag in the scheduling framework.

Does this PR introduce a user-facing change?:

Adds back support for AlwaysCheckAllPredicates flag.

/cc @Huang-Wei

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 20, 2019
Huang-Wei
Huang-Wei reviewed Dec 20, 2019
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Just a comment is that we may need at least UT to verify it really works.

@ahg-g
Copy link
Member Author

ahg-g commented Dec 20, 2019

LGMT. Just a comment is that we may need at least UT to verify it really works.

yeah, I will add a UT in this PR, but first just wanted to check if this approach is ok

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2019
@ahg-g
Copy link
Member Author

ahg-g commented Dec 20, 2019

LGMT. Just a comment is that we may need at least UT to verify it really works.

yeah, I will add a UT in this PR, but first just wanted to check if this approach is ok

unit test added

@ahg-g ahg-g mentioned this pull request Dec 20, 2019
Merged
@Huang-Wei
Copy link
Member

unit test added

Neat!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest

3 similar comments
@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest

@Huang-Wei
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest

1 similar comment
@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2019
@ahg-g
Copy link
Member Author

ahg-g commented Dec 21, 2019

@Huang-Wei fixed a conflict after #86369 got merged.

@ahg-g
Copy link
Member Author

ahg-g commented Dec 23, 2019

/cc @draveness

Wei is on vacation, please take a look if you have time.

draveness
draveness approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the work!

/lgtm
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 06fb3eb into kubernetes:master Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 23, 2019
@ahg-g ahg-g deleted the ahg1-check branch January 10, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@draveness draveness draveness approved these changes

Assignees

@Huang-Wei Huang-Wei

@draveness draveness

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@ahg-g @k8s-ci-robot @Huang-Wei @fejta-bot @draveness