Skip to content

/ kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AlwaysCheckAllPredicates in the scheduler framework. #86496

Merged
merged 1 commit into from Dec 23, 2019
Merged

Support AlwaysCheckAllPredicates in the scheduler framework. #86496

merged 1 commit into from Dec 23, 2019
+109 −34

Conversation

@ahg-g
Copy link
Member

ahg-g commented Dec 20, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds support for AlwaysCheckAllPredicates flag in the scheduling framework.

Does this PR introduce a user-facing change?:

Adds back support for AlwaysCheckAllPredicates flag.

/cc @Huang-Wei
@k8s-ci-robot k8s-ci-robot requested a review from Huang-Wei Dec 20, 2019
@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Huang-Wei
Huang-Wei reviewed Dec 20, 2019
View changes
Copy link
Member

Huang-Wei left a comment

LGMT. Just a comment is that we may need at least UT to verify it really works.
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 20, 2019

LGMT. Just a comment is that we may need at least UT to verify it really works.

yeah, I will add a UT in this PR, but first just wanted to check if this approach is ok
@ahg-g ahg-g force-pushed the ahg-g:ahg1-check branch from 65c7f49 to fd0a7bf Dec 20, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Dec 20, 2019
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 20, 2019

LGMT. Just a comment is that we may need at least UT to verify it really works.

yeah, I will add a UT in this PR, but first just wanted to check if this approach is ok

unit test added
@ahg-g ahg-g mentioned this pull request Dec 20, 2019
Merged
@Huang-Wei

This comment has been minimized.

Sign in to view
Copy link
Member

Huang-Wei commented Dec 20, 2019

unit test added

Neat!

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 20, 2019
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest
3 similar comments
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest
@Huang-Wei

This comment has been minimized.

Sign in to view
Copy link
Member

Huang-Wei commented Dec 21, 2019

/retest
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Dec 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
1 similar comment
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

fejta-bot commented Dec 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest
1 similar comment
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

/retest
@ahg-g
Added back the flag to trigger examining all Filters in the scheduler.
Loading status checks…
eeb8a5b
@ahg-g ahg-g force-pushed the ahg-g:ahg1-check branch from fd0a7bf to eeb8a5b Dec 21, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 21, 2019
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 21, 2019

@Huang-Wei fixed a conflict after #86369 got merged.
@ahg-g

This comment has been minimized.

Sign in to view
Copy link
Member Author

ahg-g commented Dec 23, 2019

/cc @draveness

Wei is on vacation, please take a look if you have time.
@k8s-ci-robot k8s-ci-robot requested a review from draveness Dec 23, 2019
@draveness
draveness approved these changes Dec 23, 2019
View changes
Copy link
Member

draveness left a comment

Great, thanks for the work!

/lgtm
/priority important-soon
@k8s-ci-robot k8s-ci-robot merged commit 06fb3eb into kubernetes:master Dec 23, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation ahg-g authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 23, 2019
@ahg-g ahg-g deleted the ahg-g:ahg1-check branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei

@draveness draveness

Assignees

@Huang-Wei Huang-Wei

@draveness draveness

Labels
approved cncf-cla: yes kind/bug lgtm priority/important-soon release-note sig/scheduling size/L
Projects
None yet
Milestone
  v1.18
5 participants
@ahg-g @k8s-ci-robot @Huang-Wei @fejta-bot @draveness
You can’t perform that action at this time.