Save log files for network proxy #87786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Jefftree
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Jefftree
force-pushed
the
netproxy-logging
branch
from
9aa9d62 to
97eed70
Compare
Jefftree
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @caesarxuchao |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @dims for approval. Thanks! |
dims
reviewed
Feb 4, 2020
| local node="${1}" | ||
| local dest_dir="${2}" | ||
|
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Log artifacts for konnectivity-server and konnectivity-agent are not saved in our e2e tests (https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-network-proxy/1224163053805768711/artifacts/bootstrap-e2e-master/). We should save those files to make debugging easier
I'm not sure how we should capture konnectivity-agent since it we may not guarantee one agent per node in the future.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @caesarxuchao