Report scheduler_perf integration test kube-scheduler metrics into artifacts dir #88162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifacts dir make test-integration ran within jenkins job does not collect json file with generated metrics from kube-scheduler. The artifacts dir needs to be set explicitly through new -data-items-dir test flag. The metrics are required to provide more comphrehensive information about kube-scheduler internals.
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-node-e2e |
|
/assign |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/sig scheduling |
k8s-ci-robot
added
sig/scheduling
liu-cong
reviewed
Feb 14, 2020
| make test-integration WHAT="$*" KUBE_TEST_ARGS="-run='XXX' -bench=${TEST_PREFIX:-.} -benchmem -alsologtostderr=false -logtostderr=false" \ | ||
| make test-integration WHAT="$*" KUBE_TEST_ARGS="-run='XXX' -bench=${TEST_PREFIX:-.} -benchmem -alsologtostderr=false -logtostderr=false -data-items-dir=${ARTIFACTS}" \ | ||
| | (go run test/integration/benchmark/extractlog/main.go) \ | ||
| | tee \ |
There was a problem hiding this comment.
These won't be needed once we switch to the new benchmark framework. Can you create an issue to track that?
ingvagabund
deleted the
scheduler-perf-metrics-report-under-artifacts-dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
make test-integration ran within jenkins job does not collect json file with generated metrics
from kube-scheduler. The artifacts dir needs to be set explicitly through new -data-items-dir
test flag. The metrics are required to provide more comphrehensive information about
kube-scheduler internals.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
New option for scheduler perf benchmark tests: https://github.com/kubernetes/kubernetes/pull/87923/files#diff-8fc16044937fc03c39b585a657b20150R46
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: