Track pods with required anti-affinity #94059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
damemi
reviewed
Aug 17, 2020
Huang-Wei
reviewed
Aug 17, 2020
soulxu
reviewed
Aug 20, 2020
k8s-ci-robot
added
size/L
ahg-g
force-pushed
the
ahg-anti-affinity
branch
from
b4d91da to
a5dae7c
Compare
|
LGTM. Please squash. |
This is a performance optimization that reduces the overhead of inter-pod affinity PreFilter calculaitons. Basically eliminates that overhead when no pods in the cluster use required pod anti-affinity. This offered 20% improvement on 5k clusters for preferred anti-affinity benchmarks.
ahg-g
force-pushed
the
ahg-anti-affinity
branch
from
a5dae7c to
a8873e1
Compare
done. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
|
/kind bug |
ahg-g
added a commit
to ahg-g/kubernetes
that referenced
this pull request
Sep 15, 2020
…pshot. Cherry pick of kubernetes#94059 on release-1.19. This is fixes a performance regression in the cluster autoscaler which started to execute PreFilter explicitly since 1.18.
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 16, 2020
…upstream-release-1.19 Automated cherry pick of #94059: Track pods with required anti-affinity
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 17, 2020
cherry pick of #94059: Track pods with required anti-affinity
liggitt
added
the
kind/regression
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a performance optimization that reduces the overhead of inter-pod affinity PreFilter calculaitons. Basically
eliminates that overhead when no pods in the cluster use required pod anti-affinity. This offered 20% improvement on 5k clusters for preferred anti-affinity benchmarks.
Does this PR introduce a user-facing change?: