Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gcp-auth-webhook image to v0.0.8 #13185

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

sharifelgamal
Copy link
Collaborator

This fixes issues that can happen with skaffold dev like GoogleContainerTools/gcp-auth-webhook#19

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 16, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13185) |
+----------------+----------+---------------------+
| minikube start | 44.7s    | 44.6s               |
| enable ingress | 27.8s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.6s 26.6s 30.1s 28.6s 25.1s
Times for minikube (PR 13185) ingress: 29.6s 30.1s 28.6s 28.1s 27.1s

Times for minikube start: 45.2s 44.0s 45.1s 43.8s 45.6s
Times for minikube (PR 13185) start: 45.2s 45.0s 44.9s 44.2s 43.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13185) |
+----------------+----------+---------------------+
| minikube start | 29.7s    | 26.4s               |
| enable ingress | 21.9s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 41.9s 26.9s 25.9s 26.7s 27.0s
Times for minikube (PR 13185) start: 25.8s 26.6s 26.2s 26.1s 27.3s

Times for minikube ingress: 21.9s 22.4s 21.4s 22.0s 21.9s
Times for minikube (PR 13185) ingress: 21.9s 22.4s 25.4s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13185) |
+----------------+----------+---------------------+
| minikube start | 43.2s    | 44.8s               |
| enable ingress | 33.4s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 44.6s 43.0s 42.8s 43.0s 42.8s
Times for minikube (PR 13185) start: 43.0s 47.3s 43.3s 44.0s 46.6s

Times for minikube ingress: 33.4s 33.4s 33.5s 33.4s 33.4s
Times for minikube (PR 13185) ingress: 33.4s 28.9s 32.4s 32.9s 29.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/Olm (gopogh) 0.00 (chart)
Docker_Linux TestRunningBinaryUpgrade (gopogh) 0.74 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh) 0.89 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 0.89 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Stop (gopogh) 0.89 (chart)
KVM_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 2.29 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/DeployApp (gopogh) 3.05 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 3.05 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/FirstStart (gopogh) 3.05 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 4.85 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 6.25 (chart)
Docker_Windows TestAddons/parallel/Olm (gopogh) 6.74 (chart)
Docker_Windows TestCertExpiration (gopogh) 6.74 (chart)
Docker_macOS TestAddons/parallel/Olm (gopogh) 9.02 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 9.02 (chart)
KVM_Linux TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 9.16 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 9.16 (chart)
Docker_Linux TestAddons/parallel/Olm (gopogh) 9.56 (chart)
none_Linux TestAddons/parallel/Olm (gopogh) 9.85 (chart)
KVM_Linux TestAddons/parallel/Olm (gopogh) 9.92 (chart)
Docker_Cloud_Shell TestAddons/parallel/Olm (gopogh) 10.17 (chart)
Hyper-V_Windows TestAddons/parallel/Olm (gopogh) 10.28 (chart)
Docker_Linux_containerd TestAddons/parallel/Olm (gopogh) 14.88 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 23.53 (chart)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 28.36 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 34.83 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 46.07 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 47.19 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 54.44 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 62.86 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit 984f3d3 into kubernetes:master Dec 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants