Skip to content

add setup readme #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

add setup readme #144

merged 1 commit into from
Jun 4, 2018

Conversation

andyxning
Copy link
Member

@andyxning andyxning commented Oct 16, 2017 •
edited
Loading

partially fix #142

This PR adds description about how to get the node-problem-detector repo and systemd build dependency.

Note: This PR should be merged only after k8s.io #85 is merged as description in this PR has go get k8s.io/node-problem-detector which is only valid after k8s.io #85 has been merged.
@Spellchaser

/cc @Random-Liu

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2017
@andyxning andyxning force-pushed the add_setup_readme branch 4 times, most recently from f3eab3d to 963a977 Compare October 16, 2017 11:44
@andyxning
Copy link
Member Author

@Random-Liu This can be merged for now as k8s.io #85 has been merged. :)

@andyxning andyxning mentioned this pull request Nov 15, 2017
Merged
@andyxning
Copy link
Member Author

Ping @Random-Liu since it seems that you comes back. :)

@andyxning
Copy link
Member Author

Ping @Random-Liu @dchen1107 to help review this.

@andyxning
Copy link
Member Author

Ping @Random-Liu @dchen1107

@andyxning
Copy link
Member Author

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@andyxning: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2018
@andyxning
Copy link
Member Author

/cc @Random-Liu to help review and add a lgtm label.

@zouyee
Copy link
Member

zouyee commented Jun 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2f915ec into kubernetes:master Jun 4, 2018
@andyxning andyxning deleted the add_setup_readme branch June 4, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@zouyee zouyee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vague|Nonexistent Build Documentation
3 participants
@andyxning @k8s-ci-robot @zouyee