Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add configs for copying GitHub releases to GCS buckets #2281

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Continuation of kubernetes-sigs/promo-tools#441.
Used by https://sigs.k8s.io/promo-tools/cmd/kpromo.
Referenced in today's SIG Release meeting.

Part of release improvements for CRI tools (kubernetes-sigs/cri-tools#616) + CNI plugins (kubernetes/sig-release#245).

Signed-off-by: Stephen Augustus foo@auggie.dev

Which issue(s) this PR fixes:

Special notes for your reviewer:

/hold for local testing

Does this PR introduce a user-facing change?

config: Add configs for copying GitHub releases to GCS buckets

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 5, 2021
@justaugustus
Copy link
Member Author

/hold cancel
/assign @cpanato @puerco @Verolop @xmudrii
cc: @kubernetes-sigs/release-engineering

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
releaseConfigs:
- org: containernetworking
repo: plugins
gcsBucket: k8s-staging-cni-plugins
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next step will be to make this bucket exist! 🙃

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a non blocking nit, otherwise LGTM

config/kpromo-gh.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0a38fe6 into kubernetes:master Oct 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants