-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add configs for copying GitHub releases to GCS buckets #2281
Conversation
Used by https://sigs.k8s.io/promo-tools/cmd/kpromo. Signed-off-by: Stephen Augustus <foo@auggie.dev>
releaseConfigs: | ||
- org: containernetworking | ||
repo: plugins | ||
gcsBucket: k8s-staging-cni-plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next step will be to make this bucket exist! 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a non blocking nit, otherwise LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Continuation of kubernetes-sigs/promo-tools#441.
Used by https://sigs.k8s.io/promo-tools/cmd/kpromo.
Referenced in today's SIG Release meeting.
Part of release improvements for CRI tools (kubernetes-sigs/cri-tools#616) + CNI plugins (kubernetes/sig-release#245).
Signed-off-by: Stephen Augustus foo@auggie.dev
Which issue(s) this PR fixes:
Special notes for your reviewer:
/hold for local testing
Does this PR introduce a user-facing change?