Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing regex match on release notes #3523

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions pkg/notes/examples/empty_multiple_sections.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
SkipHealthzCheck snuck in there while I was working on the test for #123003, but is ultimately not necessary to test the functionality. Somehow it merged despite failing the goroutine leak check fairly often on my machine

skipping healthz check resulted in leaking goroutines from poststarthooks sometimes when running TestCRDsOnStartup. Manually tested with stress that it no longer flakes (and that it did flake before).

before:

```
1m0s: 8 runs so far, 8 failures (100.00%)
1m5s: 8 runs so far, 8 failures (100.00%)
1m10s: 8 runs so far, 8 failures (100.00%)
1m15s: 8 runs so far, 8 failures (100.00%)
```

after

```
30s: 3 runs so far, 0 failures
35s: 5 runs so far, 0 failures
40s: 13 runs so far, 0 failures
45s: 13 runs so far, 0 failures
50s: 13 runs so far, 0 failures
55s: 13 runs so far, 0 failures
1m0s: 15 runs so far, 0 failures
```

#### What type of PR is this?

/kind cleanup /kind failing-test /kind flake
#### What this PR does / why we need it:
#### Which issue(s) this PR fixes:

Fixes #
#### Special notes for your reviewer:
#### Does this PR introduce a user-facing change?

```

```

#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

```

```
23 changes: 23 additions & 0 deletions pkg/notes/examples/empty_notes.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#### What type of PR is this?

/kind cleanup
#### What this PR does / why we need it:

* updates opencontainers/selinux to v1.11.0


#### Which issue(s) this PR fixes:

Fixes #
#### Special notes for your reviewer:
#### Does this PR introduce a user-facing change?

```

```

#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

```

```
44 changes: 26 additions & 18 deletions pkg/notes/notes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package notes

import (
"context"
_ "embed"
"fmt"
"net/url"
"os"
Expand Down Expand Up @@ -301,6 +302,9 @@ func TestNoteTextFromString(t *testing.T) {
}
}

//go:embed examples/empty_notes.txt
var emptyNotes string

func TestMatchesExcludeFilter(t *testing.T) {
for _, tc := range []struct {
input string
Expand All @@ -327,24 +331,28 @@ func TestMatchesExcludeFilter(t *testing.T) {
shouldExclude: false,
},
{
input: `@kubernetes/sig-auth-pr-reviews
/milestone v1.19
/priority important-longterm
/kind cleanup
/kind deprecation

xref: #81126
xref: #81152
xref: https://github.com/kubernetes/website/pull/19630

` + mdSep + `release-note
Action Required: Support for basic authentication via the --basic-auth-file flag has been removed. Users should migrate to --token-auth-file for similar functionality.
` + mdSep + `

` + mdSep + `docs
Removed "Static Password File" section from https://kubernetes.io/docs/reference/access-authn-authz/authentication/#static-password-file
https://github.com/kubernetes/website/pull/19630
` + mdSep,
input: emptyNotes,
shouldExclude: true,
},
{
input: `@kubernetes/sig-auth-pr-reviews
/milestone v1.19
/priority important-longterm
/kind cleanup
/kind deprecation

xref: #81126
xref: #81152
xref: https://github.com/kubernetes/website/pull/19630

` + mdSep + `release-note
Action Required: Support for basic authentication via the --basic-auth-file flag has been removed. Users should migrate to --token-auth-file for similar functionality.
` + mdSep + `

` + mdSep + `docs
Removed "Static Password File" section from https://kubernetes.io/docs/reference/access-authn-authz/authentication/#static-password-file
https://github.com/kubernetes/website/pull/19630
` + mdSep,
shouldExclude: false,
},
} {
Expand Down
Loading