-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path for kubelet.env file in kubelet deb package #3625
Fix path for kubelet.env file in kubelet deb package #3625
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/priority important-soon |
$ dpkg -L kubelet | grep /kubelet
/etc/default/kubelet
/lib/systemd/system/kubelet.service
/usr/bin/kubelet
/usr/share/doc/kubelet
/usr/share/doc/kubelet/LICENSE
/usr/share/doc/kubelet/README.md
/var/lib/kubelet
/var/lib/kubelet/.kubelet-keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but the release note has a typo deafult
@saschagrunert Good point, fixed! 😅 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
We received two reports that our
kubelet
Debian package installskubelet.env
file in a wrong location:I was able to confirm these reports. As per some guidelines:
/etc/default
should be used on Debian-based operating systems/etc/sysconfig
should be used on RPM-based operating systemsWe partially fixed the issue a while ago with #3279, by ensuring that
kubeadm
is going to read the file from the correct path, but we didn't ensure that we install the file in the correct location. This is now fixed with this PR.I tried building and installing the package locally to make sure the file is created in the correct location. This change will be applied to all
kubelet
packages that we build (for all minor releases) once this PR is merged. I don't expect this to regress in any way. 🤞Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato @puerco
cc @kubernetes/release-engineering