-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kubeadm >=1.32 dependency from crictl #3626
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for the next release cycle (1.32) |
The merge of kubernetes/kubernetes#124685 will make kubeadm work without crictl. We now reflect that in the packaging as well as defined in kubernetes/kubeadm#3064. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
ced4ba4
to
bc7e6ab
Compare
I changed the versions so we may not need the hold :) |
Okay, the title is enough to tell us when it should be merged. /hold cancel |
@carlory: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@saschagrunert @carlory If we're confident that the referenced k/k PRs will be merged, we can merge this PR now (once the comment I left is resolved). This change will be only applied on package versions starting from 1.32.0, earlier version are unaffected. |
/cc @neolit123 @pacoxu |
/hold the |
sorry missed the comment. yes, but we should wait until the k/k PR and k/website changes merge at least. we can also actually wait for 1.32 and see if there is any negative feedback about it during the 1.31 cycle. |
@neolit123 @kubernetes/release-managers can we unhold this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks
/hold cancel
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The merge of kubernetes/kubernetes#124685 will make kubeadm work without crictl. We now reflect that in the packaging as well as defined in kubernetes/kubeadm#3064.
Which issue(s) this PR fixes:
Refers to kubernetes/kubeadm#3064
Special notes for your reviewer:
cc @neolit123 @carlory
Does this PR introduce a user-facing change?