-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blkio for iops limit support in the future #29
Conversation
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few comments @pacoxu
i don't object to the change but we need to be clear about the scope.
before the 1.24 release we can create a new release of this library and vendor it in k/k.
- go support to 1.16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code changes LGTM, minus this comment about minimum go version:
#29 (comment)
if we can't avoid bumping to 1.16 it's fine.
If I drop the go version bumping(with golang format) commit, the verify ci will fail like https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/system-validators/29/pull-system-validators-verify/1497038772368314368. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, understood. This is fine.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #28
The support of iops in kubernetes and contained can be found and tracked in kubernetes/kubernetes#92287 (comment) and kubernetes/enhancements#1907, containerd/containerd#5490, cri-o/cri-o#4873.