Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blkio for iops limit support in the future #29

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 22, 2022

Fixes #28

The support of iops in kubernetes and contained can be found and tracked in kubernetes/kubernetes#92287 (comment) and kubernetes/enhancements#1907, containerd/containerd#5490, cri-o/cri-o#4873.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@pacoxu
Copy link
Member Author

pacoxu commented Feb 22, 2022

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2022
validators/types_unix.go Outdated Show resolved Hide resolved
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments @pacoxu
i don't object to the change but we need to be clear about the scope.

before the 1.24 release we can create a new release of this library and vendor it in k/k.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code changes LGTM, minus this comment about minimum go version:
#29 (comment)

if we can't avoid bumping to 1.16 it's fine.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Feb 25, 2022

If I drop the go version bumping(with golang format) commit, the verify ci will fail like https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/system-validators/29/pull-system-validators-verify/1497038772368314368.

@pacoxu
Copy link
Member Author

pacoxu commented Feb 25, 2022

root@pacoall ~]# docker run -it --entrypoint=bash  gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220221-c13e827224-master
root@427ff46eeefa:/workspace# go version
go version go1.17.7 linux/amd64

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, understood. This is fine.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kernel cgroup v2 support update
4 participants