Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DaemonSetUpdateSurge feature from alpha #22263

Merged
merged 1 commit into from
May 26, 2021
Merged

Remove DaemonSetUpdateSurge feature from alpha #22263

merged 1 commit into from
May 26, 2021

Conversation

ravisantoshgudimetla
Copy link
Contributor

This feature is graduating to beta now: kubernetes/kubernetes#101742

kubernetes/enhancements#2665

@ravisantoshgudimetla
Remove DaemonSetUpdateSurge feature from alpha
4c3ae82 
This feature is graduating to beta now
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 19, 2021
@ravisantoshgudimetla
Copy link
Contributor Author

cc @soltysh @smarterclayton

soltysh
soltysh approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@ravisantoshgudimetla
Copy link
Contributor Author

cc @justaugustus for approval. I got approval from sig ^

@ravisantoshgudimetla
Copy link
Contributor Author

/assign @cheftako

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, ravisantoshgudimetla, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8d43c1d into kubernetes:master May 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 26, 2021
@k8s-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

This feature is graduating to beta now: kubernetes/kubernetes#101742

kubernetes/enhancements#2665

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@soltysh soltysh

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@ravisantoshgudimetla @cheftako @k8s-ci-robot @soltysh