Add a presubmit job for k8s-multicluster-ingress #5373

nikhiljindal · 2017-11-07T01:46:51Z

Adding a presubmit job for github.com/GoogleCloudPlatform/k8s-multicluster-ingress.

nikhiljindal · 2017-11-07T01:48:12Z

@krzyzacy I definitely dont understand all the changes here. Followed the changes for another similar job :)
Please take a look and let me know if I am doing something silly, which is totally possible :)

krzyzacy · 2017-11-07T01:51:02Z

jobs/config.json

@@ -9300,6 +9300,15 @@
      "sig-network"
    ]
  },
+  "pull-kubernetes-multicluster-ingress-test": {
+    "args": [
+      "true"


do you actually want to run something useful? xD

Added "make test" here. It should start working once GoogleCloudPlatform/k8s-multicluster-ingress#62 merges.

krzyzacy · 2017-11-07T01:53:02Z

prow/plugins.yaml

@@ -119,3 +119,6 @@ plugins:
  - reopen
  - lgtm
  - trigger
+
+  GoogleCloudPlatform/k8s-multicluster-ingress:


If you look at top of this file, the repo need to be configured to send prow webhooks, also send an invitation to @k8s-ci-robot to make it work. Are you the owner of this repo?

No instructions at the top of the file, but done and done

cc @cjwagner maybe we want to put in some internal docs so that we know where to find different things

ALso added GoogleCloudPlatform/k8s-multicluster-ingress to the top of file

krzyzacy · 2017-11-09T19:52:32Z

jobs/config.json is not sorted, please run bazel run //jobs:config_sort

nikhiljindal · 2017-11-09T19:56:53Z

aah didnt realize that its sorted. Done it now

krzyzacy · 2017-11-09T20:05:51Z

/lgtm

k8s-ci-robot · 2017-11-09T20:05:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, nikhiljindal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [krzyzacy]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-ci-robot · 2017-11-09T21:46:13Z

@nikhiljindal: I updated Prow config for you!

I updated Prow plugins config for you!

In response to this:

Adding a presubmit job for github.com/GoogleCloudPlatform/k8s-multicluster-ingress.

cc @krzyzacy @G-Harmon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nikhiljindal · 2017-11-09T23:48:45Z

@krzyzacy The tests are failing and link to logs is not working: GoogleCloudPlatform/k8s-multicluster-ingress#41 (comment).
Any idea why?

BenTheElder · 2017-11-10T00:04:11Z

prow/config.yaml

+          readOnly: true
+        - name: cache-ssd
+          mountPath: /root/.cache
+        ports:


I don't think this needs this port

BenTheElder · 2017-11-10T00:06:41Z

I'm investigating, currently your job is pending, I think waiting for a free node with that port available. We should probably remove that from the spec in a follow up, we use that as a hack to make sure the bazel jobs aren't using the bazel cache concurrently.

BenTheElder · 2017-11-10T00:44:03Z

http://prow.k8s.io/log?job=pull-kubernetes-multicluster-ingress-test&id=11

I1110 00:40:34.302] Call:  git fetch --quiet --tags https://github.com/k8s-multicluster-ingress master +refs/pull/41/head:refs/pr/41
W1110 00:40:34.504] remote: Not Found
W1110 00:40:34.504] fatal: repository 'https://github.com/k8s-multicluster-ingress/' not found
E1110 00:40:34.507] Command failed
I1110 00:40:34.507] process 23 exited with code 128 after 0.0m
W1110 00:40:34.507] git fetch failed
I1110 00:40:34.874] Call:  git fetch --quiet --tags https://github.com/k8s-multicluster-ingress master +refs/pull/41/head:refs/pr/41
W1110 00:40:35.074] remote: Not Found
W1110 00:40:35.074] fatal: repository 'https://github.com/k8s-multicluster-ingress/' not found
E1110 00:40:35.076] Command failed
I1110 00:40:35.076] process 26 exited with code 128 after 0.0m
W1110 00:40:35.077] git fetch failed
I1110 00:40:36.890] Call:  git fetch --quiet --tags https://github.com/k8s-multicluster-ingress master +refs/pull/41/head:refs/pr/41
W1110 00:40:37.104] remote: Not Found
W1110 00:40:37.105] fatal: repository 'https://github.com/k8s-multicluster-ingress/' not found
E1110 00:40:37.107] Command failed
I1110 00:40:37.107] process 29 exited with code 128 after 0.0m
E1110 00:40:37.107] unexpected error
Traceback (most recent call last):
  File "./test-infra/jenkins/bootstrap.py", line 926, in bootstrap
  File "./test-infra/jenkins/bootstrap.py", line 841, in setup_root
  File "./test-infra/jenkins/bootstrap.py", line 248, in checkout
  File "./test-infra/jenkins/bootstrap.py", line 906, in <lambda>
  File "./test-infra/jenkins/bootstrap.py", line 147, in _call

BenTheElder · 2017-11-10T00:45:31Z

prow/config.yaml

+      containers:
+      - image: gcr.io/k8s-testimages/gcloud-in-go:0.4
+        args:
+        - "--repo=github.com/$(REPO_NAME)=$(PULL_REFS)"


this needs to be "--repo=github.com/GoogleCloudPlatform/$(REPO_NAME)=$(PULL_REFS)"

oh right, good catch

nikhiljindal · 2017-11-10T05:36:53Z

Thanks for the investigation @BenTheElder!
Sent #5438 for the fixes.

Are the instructions for debugging this documented somewhere?
I tried the link you posted (http://prow.k8s.io/log?job=pull-kubernetes-multicluster-ingress-test&id=11) and I get a 404. Is that link only valid when the job is running?

BenTheElder · 2017-11-10T05:51:12Z

@nikhiljindal I don't think we have instructions for debugging this anywhere, but generally the prow log links (which are at the ≡ on each job's entry on prow.k8s.io) are usually all you need.

Is that link only valid when the job is running?

more or less, the pods do get GC'd, it's only meant to be used while running but is still valid for a bit. It's especially useful when the logs don't upload.

BenTheElder · 2017-11-10T06:19:32Z

jobs/config.json

@@ -9349,6 +9349,15 @@
      "sig-scalability"
    ]
  },
+  "pull-kubernetes-multicluster-ingress-test": {
+    "args": [
+      "make test"


Oh and this needs to be an arg array 😞

"args": [ "make", "test" ]

fixed in #5439

nikhiljindal requested review from BenTheElder, cjwagner, 0xmichalis and krzyzacy as code owners November 7, 2017 01:46

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2017

krzyzacy reviewed Nov 7, 2017

View reviewed changes

nikhiljindal force-pushed the kubemci branch from b6b9a21 to 8c00b36 Compare November 9, 2017 19:34

nikhiljindal mentioned this pull request Nov 9, 2017

Adding a Makefile GoogleCloudPlatform/k8s-multicluster-ingress#62

Merged

Add a presubmit for k8s-multicluster-ingress

660fefb

nikhiljindal force-pushed the kubemci branch from 8c00b36 to 660fefb Compare November 9, 2017 19:56

k8s-ci-robot assigned krzyzacy Nov 9, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2017

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017

k8s-ci-robot merged commit 1dcc85f into kubernetes:master Nov 9, 2017

BenTheElder reviewed Nov 10, 2017

View reviewed changes

prow/config.yaml

readOnly: true

- name: cache-ssd

mountPath: /root/.cache

ports:

Copy link

Member

BenTheElder Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs this port

BenTheElder reviewed Nov 10, 2017

View reviewed changes

nikhiljindal mentioned this pull request Nov 10, 2017

Fixing the prow config for multicluster test job #5438

Merged

BenTheElder reviewed Nov 10, 2017

View reviewed changes

nikhiljindal mentioned this pull request Nov 13, 2017

Testing improvements GoogleCloudPlatform/k8s-multicluster-ingress#48

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a presubmit job for k8s-multicluster-ingress #5373

Add a presubmit job for k8s-multicluster-ingress #5373

nikhiljindal commented Nov 7, 2017 •

edited

Loading

nikhiljindal commented Nov 7, 2017

krzyzacy Nov 7, 2017

nikhiljindal Nov 9, 2017

krzyzacy Nov 7, 2017

nikhiljindal Nov 9, 2017

krzyzacy Nov 9, 2017

nikhiljindal Nov 9, 2017

krzyzacy commented Nov 9, 2017 •

edited

Loading

nikhiljindal commented Nov 9, 2017

krzyzacy commented Nov 9, 2017

k8s-ci-robot commented Nov 9, 2017

k8s-ci-robot commented Nov 9, 2017

nikhiljindal commented Nov 9, 2017

BenTheElder Nov 10, 2017

BenTheElder commented Nov 10, 2017

BenTheElder commented Nov 10, 2017

BenTheElder Nov 10, 2017

krzyzacy Nov 10, 2017

nikhiljindal commented Nov 10, 2017 •

edited

Loading

BenTheElder commented Nov 10, 2017

BenTheElder Nov 10, 2017

BenTheElder Nov 10, 2017

Add a presubmit job for k8s-multicluster-ingress #5373

Add a presubmit job for k8s-multicluster-ingress #5373

Conversation

nikhiljindal commented Nov 7, 2017 • edited Loading

nikhiljindal commented Nov 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krzyzacy commented Nov 9, 2017 • edited Loading

nikhiljindal commented Nov 9, 2017

krzyzacy commented Nov 9, 2017

k8s-ci-robot commented Nov 9, 2017

k8s-ci-robot commented Nov 9, 2017

@nikhiljindal: I updated Prow config for you!

nikhiljindal commented Nov 9, 2017

Choose a reason for hiding this comment

BenTheElder commented Nov 10, 2017

BenTheElder commented Nov 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented Nov 10, 2017 • edited Loading

BenTheElder commented Nov 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented Nov 7, 2017 •

edited

Loading

krzyzacy commented Nov 9, 2017 •

edited

Loading

nikhiljindal commented Nov 10, 2017 •

edited

Loading