Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary list of core objects is wrong #45972

Closed
sftim opened this issue Apr 23, 2024 · 13 comments
Closed

Glossary list of core objects is wrong #45972

sftim opened this issue Apr 23, 2024 · 13 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Apr 23, 2024

This is a Bug Report

Problem:

The glossary listing for core objects includes several things that aren't core object kinds, such as:

  • Pod Security Policy (removed!)
  • Quantity (not an API kind that you can create using kubectl etc)
  • Dynamic Volume Provisioning (not an API kind at all)
  • Cloud Controller Manager (a binary, not an API kind)
  • Taint (a fundamental concept, but not an API kind)
  • Volume (not an API kind that you can create using kubectl etc)
  • Volume Plugin (not an API kind at all)
  • QoS Class (not an API kind)

Proposed Solution:

Edit those glossary entries. Optionally add in glossary entries for all core object kinds; for example, NetworkPolicy, Node and PodTemplate should be in the list.

Page to Update:
https://k8s.io/docs/reference/glossary/?core-object=true

Additional Information:
/language en

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 23, 2024
@dipesh-rawat
Copy link
Member

We should fix this.

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2024
@dipesh-rawat
Copy link
Member

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 23, 2024
@sftim
Copy link
Contributor Author

sftim commented Apr 23, 2024

PRs that cover just one entry at a time are very welcome.

@mguan2020
Copy link
Contributor

/assign

@shannonxtreme
Copy link
Contributor

In general, do the glossary categories correspond to the API categories? If they aren't, should they be so that new additions are easier to put into buckets? If they are, are we socializing that information well (like with comments in the source directory or style guide)?

@sftim
Copy link
Contributor Author

sftim commented Apr 30, 2024

We don't really have API categories.

https://kubernetes.io/docs/reference/kubernetes-api/ does have some categories, but (IIRC) this SIG and its tech leads at the time were keen to de-emphasize or drop them.

@sftim
Copy link
Contributor Author

sftim commented Apr 30, 2024

Putting APIs into categories or a taxonomy might be useful, but it makes work for maintainers that I think isn't justified by the value you get from it.

@sftim
Copy link
Contributor Author

sftim commented Apr 30, 2024

BTW I'm taking “core object” to mean “API kinds built in to Kubernetes”, and not “API kinds in the core API group”.

@vaibhav2107
Copy link
Member

@mguan2020 Are you still working on this issue?

@abhilasha2418
Copy link
Contributor

/assign

@vaibhav2107
Copy link
Member

As the PR #48333 has been merged so we can close this issue

@vaibhav2107
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@vaibhav2107: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants