Storage class 1.4 docs #1243
Merged
Storage class 1.4 docs #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks the same as before, therefore lgtm from my side. |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
Currently the shown example of a Ingress resource with the service-upstream annotation is invalid in that the annotations value is a boolean where only string values are allowed. This change updates the example to be valid. Signed-off-by: Crevil <bjoern.soerensen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this should not need a review because it is simply reverting a revert in the release-1.4 branch. Bear with me... The first commit is #1064 and the second commit is #1121. Only, this time I am targeting them at the correct branch, 1.4.
This change is