Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/reference/glossary/sig.md #17461

Closed
wants to merge 2 commits into from
Closed

Add content/es/docs/reference/glossary/sig.md #17461

wants to merge 2 commits into from

Conversation

luiscachog
Copy link
Contributor

New page translation: content/es/docs/reference/glossary/sig.md

Tracked:
Issue: #13948
Comment: #13948 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

@k4ch0: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign raelga
You can assign the PR to them by writing /assign @raelga in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 6, 2019
@netlify
Copy link

netlify bot commented Nov 6, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4c53009

https://deploy-preview-17461--kubernetes-io-master-staging.netlify.com

@raelga raelga changed the title Add content/es/docs/reference/glossary/sig.md Add content/es/docs/reference/glossary/label.md Nov 18, 2019
@raelga raelga changed the title Add content/es/docs/reference/glossary/label.md Add content/es/docs/reference/glossary/sig.md Nov 18, 2019
raelga
raelga requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k4ch0 puedes hacer un rebase de la rama de la PR? Parece que no está actualizada.

Puedes encontrar algo de documentación sobre el flujo de GitHub en https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md. No dudes en preguntarme por Slack si tienes alguna duda!

Por otro lado, el término sig ya estaba en castellano tras: #17147.

Por lo que seguramente se podría cerrar esta PR, qué te parece?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@raelga raelga added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Nov 18, 2019
@luiscachog
Copy link
Contributor Author

Closing as SIG PR is already accepted on #17147

@luiscachog luiscachog closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga requested changes

@alexbrand alexbrand Awaiting requested review from alexbrand

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/es Issues or PRs related to Spanish language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luiscachog @k8s-ci-robot @raelga