Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Sidecar documentation #19046

Closed
wants to merge 1 commit into from
Closed

[WIP] Sidecar documentation #19046

wants to merge 1 commit into from

Conversation

Joseph-Irving
Copy link
Member

Placeholder PR for kubernetes/enhancements#753

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d2dcca2

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5e4114583ba99c000c9e7aa3

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2020
@Joseph-Irving Joseph-Irving mentioned this pull request Feb 10, 2020
Open
11 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jimangel
You can assign the PR to them by writing /assign @jimangel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

@Joseph-Irving: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makoscafee
Copy link
Contributor

/milestone 1.18

@k8s-ci-robot k8s-ci-robot added this to the 1.18 milestone Feb 19, 2020
@irvifa
Copy link
Member

irvifa commented Mar 6, 2020

Related to:
kubernetes/kubernetes#79649
kubernetes/kubernetes#80744

@Joseph-Irving
Copy link
Member Author

This feature will not be in 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@Joseph-Irving @k8sio-netlify-preview-bot @k8s-ci-robot @makoscafee @irvifa