Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set feature state version for kubelet config task #20766

Merged
merged 1 commit into from
May 5, 2020
Merged

Set feature state version for kubelet config task #20766

merged 1 commit into from
May 5, 2020

Conversation

prasadkatti
Copy link
Contributor

@prasadkatti prasadkatti commented May 4, 2020 •
edited
Loading

Fixes #20692

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 4, 2020
@netlify
Copy link

netlify bot commented May 4, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1256273

https://deploy-preview-20766--kubernetes-io-master-staging.netlify.app

@prasadkatti
Copy link
Contributor Author

/assign @kbhawkey
Hi. I need help with PR title.

@kbhawkey
Copy link
Contributor

kbhawkey commented May 5, 2020

How about something like:
Set feature state version for kubelet config task

@prasadkatti prasadkatti changed the title Update version for when "Set Kubelet parameters via a config file" re… Set feature state version for kubelet config task May 5, 2020
@prasadkatti
Copy link
Contributor Author

Thanks @kbhawkey. I will force push the commit with the right commit msg.

@kbhawkey
Copy link
Contributor

kbhawkey commented May 5, 2020

Page preview:
https://deploy-preview-20766--kubernetes-io-master-staging.netlify.app/docs/tasks/administer-cluster/kubelet-config-file/

@kbhawkey
Copy link
Contributor

kbhawkey commented May 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2020
@kbhawkey
Copy link
Contributor

kbhawkey commented May 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 93e2ae3 into kubernetes:master May 5, 2020
@prasadkatti prasadkatti deleted the patch-2 branch May 5, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen Awaiting requested review from mtaufen

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent version, feature state for tasks/administer-cluster/kubelet-config-file
3 participants
@prasadkatti @kbhawkey @k8s-ci-robot