-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate kubelet client certificates GA, CSR API GA #21108
Conversation
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 78d4a10 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0f32ab7c646900077f6bf8 |
/milestone 1.19 |
content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks ready for tech review.
/assign |
Hi @liggitt, docs shadow here 👋 just a friendly reminder this PR needs tech and doc review by July 16th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've got time to pick up some nits, here are things I identified.
content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
Outdated
Show resolved
Hide resolved
pushed update addressing comments and fixing rebase issue to https://github.com/liggitt/kubernetes-website/commits/csr-ga but github is not showing it here for some reason |
/cc @deads2k |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the comments have been addressed and the PR looks good. Merging it 🎉
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitharaghunathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docs for: