Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate kubelet client certificates GA, CSR API GA #21108

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Rotate kubelet client certificates GA, CSR API GA #21108

merged 2 commits into from
Jul 15, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 21, 2020 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 21, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 21, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 78d4a10

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0f32ab7c646900077f6bf8

@liggitt liggitt mentioned this pull request May 21, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 21, 2020
@sftim
Copy link
Contributor

sftim commented May 21, 2020

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone May 21, 2020
@liggitt liggitt changed the title WIP - Rotate kubelet client certificates GA WIP - Rotate kubelet client certificates GA, CSR API GA Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2020
@liggitt liggitt mentioned this pull request Jun 1, 2020
Closed
@tengqm tengqm mentioned this pull request Jun 14, 2020
Merged
@liggitt liggitt changed the title WIP - Rotate kubelet client certificates GA, CSR API GA Rotate kubelet client certificates GA, CSR API GA Jul 6, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2020
sftim
sftim reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks ready for tech review.

@savitharaghunathan
Copy link
Member

/assign

@annajung
Copy link
Contributor

annajung commented Jul 13, 2020 •
edited
Loading

Hi @liggitt, docs shadow here 👋 just a friendly reminder this PR needs tech and doc review by July 16th.
Plus, there is a file conflict that needs to be addressed

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2020
sftim
sftim reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've got time to pick up some nits, here are things I identified.

content/en/docs/reference/access-authn-authz/certificate-signing-requests.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/certificate-signing-requests.md Outdated Show resolved Hide resolved
@liggitt
Copy link
Member Author

liggitt commented Jul 15, 2020

pushed update addressing comments and fixing rebase issue to https://github.com/liggitt/kubernetes-website/commits/csr-ga but github is not showing it here for some reason

@liggitt
Copy link
Member Author

liggitt commented Jul 15, 2020

/cc @deads2k

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2020
@deads2k
Copy link
Contributor

deads2k commented Jul 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
savitharaghunathan
savitharaghunathan reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments have been addressed and the PR looks good. Merging it 🎉

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit c26fdeb into kubernetes:dev-1.19 Jul 15, 2020
@liggitt liggitt deleted the csr-ga branch August 28, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@jcbsmpsn jcbsmpsn Awaiting requested review from jcbsmpsn

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@savitharaghunathan savitharaghunathan

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @k8sio-netlify-preview-bot @sftim @savitharaghunathan @annajung @deads2k @k8s-ci-robot