Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark RotateKubeletClientCertificate GA #21697

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Mark RotateKubeletClientCertificate GA #21697

merged 1 commit into from
Jun 24, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 13, 2020

closes: #21696

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 33d2138

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ee448640f09db000748cee3

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 13, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jun 13, 2020

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone Jun 13, 2020
sftim
sftim previously requested changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm you might want to revise content/en/docs/tasks/tls/certificate-rotation.md. What do you think?

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Jun 14, 2020

This change on its own isn't wrong; however, to do all the work we also need to revise content/en/docs/tasks/tls/certificate-rotation.md to drop mention of the RotateKubeletClientCertificate feature gate.
@tengqm how do you want to move forward on that?

@tengqm
Copy link
Contributor Author

tengqm commented Jun 14, 2020

@sftim The mentioned page has been taken care of by liggit (#21108)

@sftim sftim dismissed their stale review June 14, 2020 17:42

Clarified

@sftim
Copy link
Contributor

sftim commented Jun 14, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jun 20, 2020

/assign @savitharaghunathan

savitharaghunathan
savitharaghunathan reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f93844f into kubernetes:dev-1.19 Jun 24, 2020
@tengqm tengqm deleted the RotateKubeletClientCertificate-119 branch July 5, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@savitharaghunathan savitharaghunathan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@tengqm @k8sio-netlify-preview-bot @sftim @k8s-ci-robot @savitharaghunathan