Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post: GSoC ‘20 - Building operators for cluster addons #23432

Merged
merged 8 commits into from
Sep 15, 2020

Conversation

somtochiama
Copy link
Member

This blog post gives an overview of the work done by @somtochiama during the Google Summer of Code internship period with Kubernetes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @somtochiama!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2020
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 25, 2020
@somtochiama
Copy link
Member Author

/assign @justinsb @stealthybox

@netlify
Copy link

netlify bot commented Aug 25, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7b5bb4d

https://deploy-preview-23432--kubernetes-io-master-staging.netlify.app

Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this Onyekwere! I've added some comments, also it might read easier if you added whitespace after the word where you use parenthesis. For example instead of this(and then text), maybe this (and some text).

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the writeup @somtochiama !
i took a quick pass on the doc and found a couple of minor nits :)

@somtochiama
Copy link
Member Author

@neolit123 @castrojo Thanks for the review😊. I have made some changes in line with your comments

@nikhita
Copy link
Member

nikhita commented Sep 14, 2020

/assign @mrbobbytables

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice article Somtochi.

I've made a few suggestions inline. The only really important one is the final comment about the link to Slack.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@somtochiama
Copy link
Member Author

@sftim Thanks for the detailed review. I have made corresponding changes.

@dholbach
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@castrojo
Copy link
Member

I think we need to update the filename and slug on the top to be a date in the future right? Otherwise it will publish it in the archives?

@dholbach
Copy link
Member

@somtochiama ^ Could you do that?

@castrojo How much in advance does it need to be? Would tomorrow be good enough? Or two days?

@castrojo
Copy link
Member

Either works for me, if possible PM me in slack as well, I don't want to get stuck in a loop where you're waiting for review and then by the time we get to it the time has passed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@dholbach
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@castrojo
Copy link
Member

/approve

Thanks for working on this everyone!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 34e2e45 into kubernetes:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants