Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote pid limits to ga #23883

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Promote pid limits to ga #23883

merged 1 commit into from
Sep 17, 2020

Conversation

SergeyKanzhelev
Copy link
Member

Follow up from kubernetes/kubernetes#94140

(used #23332 as an example)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 14, 2020
@kbhawkey
Copy link
Contributor

Hi @SergeyKanzhelev .
It looks like these changes are meant for the v1.20 release.
You should create your changes on the dev-1.20 branch instead of the master branch.
Thanks!
/cc @annajung

@SergeyKanzhelev SergeyKanzhelev changed the base branch from master to dev-1.20 September 14, 2020 18:45
@SergeyKanzhelev
Copy link
Member Author

Hi @SergeyKanzhelev .
It looks like these changes are meant for the v1.20 release.
You should create your changes on the dev-1.20 branch instead of the master branch.
Thanks!
/cc @annajung

sorry, fixed.

@netlify
Copy link

netlify bot commented Sep 14, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6125077

https://deploy-preview-23883--kubernetes-io-master-staging.netlify.app

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 15, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit ecf851c

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f6256419ad19200086b0249

@tengqm
Copy link
Contributor

tengqm commented Sep 15, 2020

/lgtm
Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@annajung
Copy link
Contributor

Hello, 1.20 docs lead here. Can we also get a lgtm from the sig? @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 15, 2020
@sftim
Copy link
Contributor

sftim commented Sep 15, 2020

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Sep 15, 2020
@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-23883--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

kbhawkey
kbhawkey reviewed Sep 16, 2020
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -290,6 +286,12 @@ different Kubernetes components.
| `SupportIPVSProxyMode` | `false` | Beta | 1.9 | 1.9 |
| `SupportIPVSProxyMode` | `true` | Beta | 1.10 | 1.10 |
| `SupportIPVSProxyMode` | `true` | GA | 1.11 | - |
| `SupportNodePidsLimit` | `false` | Alpha | 1.14 | 1.14 |
| `SupportNodePidsLimit` | `true` | Beta | 1.15 | 1.19 |
| `SupportNodePidsLimit` | `true` | GA | 1.20 | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev , would you have time to add a description for SupportNodePidsLimit (~ line 535) similar to:

SupportPodPidsLimit: Enable the support to limiting PIDs in Pods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@kbhawkey
Copy link
Contributor

LGTM

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Sep 16, 2020
Merged
@tengqm
Copy link
Contributor

tengqm commented Sep 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@kbhawkey
Copy link
Contributor

Thanks @SergeyKanzhelev
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit a604926 into kubernetes:dev-1.20 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@annajung annajung Awaiting requested review from annajung

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
7 participants
@SergeyKanzhelev @kbhawkey @k8sio-netlify-preview-bot @tengqm @annajung @sftim @k8s-ci-robot