Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: fix Korean translation of 'object' #25370

Merged

Conversation

yoonian
Copy link
Contributor

@yoonian yoonian commented Dec 3, 2020

Corrects Korean translation of object according to 용어집.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 3, 2020
@yoonian yoonian changed the title fix Korean translation of 'object' ko: fix Korean translation of 'object' Dec 3, 2020
@netlify
Copy link

netlify bot commented Dec 3, 2020

✔️ Deploy preview for k8s-dev-ko ready!

🔨 Explore the source changes: 07f2155

🔍 Inspect the deploy logs: https://app.netlify.com/sites/k8s-dev-ko/deploys/5fcc9654af61220008dcfd48

😎 Browse the preview: https://deploy-preview-25370--k8s-dev-ko.netlify.app

Copy link
Contributor

@pjhwa pjhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonian 컨트리뷰션 감사합니다!

기존 내용에 일부 오타나 띄어쓰기 오류가 있어 확인하시어 수정 부탁드립니다. ^^

@pjhwa
Copy link
Contributor

pjhwa commented Dec 3, 2020

/assign

@pjhwa
Copy link
Contributor

pjhwa commented Dec 4, 2020

@yoonian 스쿼시 작업 부탁드립니다. LGTM입니다. 👍

@pjhwa
Copy link
Contributor

pjhwa commented Dec 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ccefa4690498675f716664d6abdb15120357d60

Co-authored-by: Jerry Park <jaehwa@gmail.com>
@seokho-son
Copy link
Member

This branch has conflicts that must be resolved
to resolve conflicts before continuing.
Conflicting files
content/ko/docs/tasks/administer-cluster/cluster-management.md

컨플릭트가 발생하였네요.. ^^ 일단 제가 임의로 수정하도록 하겠습니다.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 6, 2020
@seokho-son
Copy link
Member

감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74ffea9205cbb3398f6ac8702d46ffe573b2e85c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7de6672 into kubernetes:dev-1.19-ko.6 Dec 6, 2020
seokho-son added a commit that referenced this pull request Dec 6, 2020
- fix Korean translation of 'object' (#25370)
- Update outdated files in the dev-1.19-ko.6 branch (2) (#25403)
- Translate setup/release/version-skew-policy.md in Korean (#25345)
- Translate tutorials/configuration/configure-java-microservice/configure-java-microservice/ into Korean (#24981)
- Translate health-checks.md into Korean (#25342)
- Translate reference/glossary/api-group.md in Korean (#25321)
- Translate reference/glossary/object.md in Korean (#25318)
- Translate tutorials/configuration/configure-java-microservice/configure-java-microservice-interactive/ into Korean (#24984)
- switch New York Times case study to use youtube shortcode (ko) (#25287)

Co-authored-by: seokho-son <shsongist@gmail.com>
Co-authored-by: Jerry Park <jaehwa@gmail.com>
Co-authored-by: PyungHo Yoon <learder@gmail.com>
Co-authored-by: mylovepooh <jun8414@gmail.com>
Co-authored-by: jmkim <jm1223.kim@samsung.com>
Co-authored-by: santachopa <santachopa@naver.com>
Co-authored-by: Arhell <arhell333@gmail.com>
@yoonian yoonian deleted the dev-1.19-ko.6-fix-object branch July 29, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants