-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] All Enhancement proposals in single webpage | KEPs #28295
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently it is showing the details in |
✔️ Deploy Preview for kubernetes-io-master-staging ready! 🔨 Explore the source changes: 292e29c 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60be5ddc2974c1000857565e 😎 Browse the preview: https://deploy-preview-28295--kubernetes-io-master-staging.netlify.app |
Hi @shekhar-rajak I want to work on this can you please provide some resources and what to do in a brief. |
HI @Rahul-D78 ,
|
Thanks @shekhar-rajak |
Search by keyword, filter by sig-group added. Now need to work on CSS part. |
Bootstrap CSS used to beautify the content: https://deploy-preview-28295--kubernetes-io-master-staging.netlify.app/keps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @shekhar-rajak
I think KEP list would actually have a better home in https://k8s.dev/ (https://github.com/kubernetes/contributor-site).
Would you like help with adapting this PR to target that other website?
/hold
(I'm open to persuasion about targeting https://kubernetes.io/ rather than https://k8s.dev/ - but I do think that https://k8s.dev/ is the obvious best home).
Agreed that k8s.dev is the right place, this is information-by-and-for-contributors. How much would have to be redone to move it there? |
Hi @shekhar-rajak . Yes, I agree with @sftim. Would you open a PR in the |
Created the PR: kubernetes/contributor-site#222 |
@shekhar-rajak hi, you probably meant @jberkus not me. |
Oops , wrong mention. Sorry! |
Oh, hey @berkus, we meet again! |
@jberkus yep, all the time :) |
This PR is for kubernetes/enhancements#2095 and we want a KEP webpage to find out about specific kep and its metadata easily.
Actual Plan:
kep_data.yaml
generated in the repo: https://github.com/kubernetes/enhancements - somewhere in data folder - This can be done by CI when new KEP is merged in the repo, it will automatically generate the kep_data.yaml file using the querygo run ./cmd/kepctl/main.go query --output yaml > data/kep_data.yaml
kep_data.yaml
will be used in this repowebsite
to put in/keps
webpage [Currently I have pushed the dump into data folder but in future we want to take it directly from theenhancements
repo]/keps
page will display the content in table and we will have search column [TODO] wise like kep-number, sig-group, kep name, etc.