Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Romana details #32937

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Apr 14, 2022

  • omit it as an example from CNI-Genie
  • update the hyperlink

Follows on to #32834

As a separate piece of work, it'd be great to switch to using the CNCF Landscape for this list - see #32778

This PR is not that fix.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 0322a37
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/625ff3e6b347de0008e6546a
😎 Deploy Preview https://deploy-preview-32937--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo
Copy link
Member

@sftim GitHub says that this branch has conflicts that must be resolved.
Please resolve conflicts. :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2022
- omit it as an example from CNI-Genie
- update the hyperlink
@sftim sftim force-pushed the 20220414_add_link_to_romana branch from 0364b6b to 0322a37 Compare April 20, 2022 11:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@sftim
Copy link
Contributor Author

sftim commented May 26, 2022

This is ready for review

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 706713d31c67388690c82318fbb2bf3f5ab0c70e

@tengqm
Copy link
Contributor

tengqm commented Jun 5, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit d2f96a9 into kubernetes:main Jun 5, 2022
@jihoon-seo
Copy link
Member

@sftim You deleted the 'Contiv' line in this PR. I wonder this was what you intended, or an accidental one.

@sftim sftim deleted the 20220414_add_link_to_romana branch June 6, 2022 11:16
@sftim
Copy link
Contributor Author

sftim commented Jun 6, 2022

Hmm. I think that was an accidental removal. Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants