Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore accidentally removed Contiv details #34171

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Restore accidentally removed Contiv details #34171

merged 1 commit into from
Jun 8, 2022

Conversation

jihoon-seo
Copy link
Member

This PR restores accidentally removed Contiv details.
/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim June 8, 2022 00:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 8, 2022
@netlify
Copy link

netlify bot commented Jun 8, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1039f1d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/629ff268c103710009317d1b
😎 Deploy Preview https://deploy-preview-34171--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

looks like this was added back in April in PR #32938
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7426fffa06b1788d733c596f3156f9581d7c836

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 090b4c4 into kubernetes:main Jun 8, 2022
@jihoon-seo jihoon-seo deleted the 220608_Restore_accidentally_removed_Contiv_details branch June 8, 2022 02:57
@t-inu t-inu mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim Awaiting requested review from sftim

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jihoon-seo @reylejano @k8s-ci-robot