Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] sync docs/reference/labels-annotations-taints/_index.md #41505

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[zh] sync docs/reference/labels-annotations-taints/_index.md #41505

merged 1 commit into from
Jul 7, 2023

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Jun 6, 2023

sync docs/reference/labels-annotations-taints/_index.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language labels Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 6, 2023
@netlify
Copy link

netlify bot commented Jun 6, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 28b683d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/647fe5ec5a537a00080fcb85
😎 Deploy Preview https://deploy-preview-41505--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

windsonsea
windsonsea reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请阅读中文本地化风格指南

content/zh-cn/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
@bzsuni
sync docs/reference/labels-annotations-taints/_index.md
28b683d 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the reference/labels-annotations-taints branch from 53e94fd to 28b683d Compare June 7, 2023 02:05
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Jun 7, 2023

Thank you very much. I have made modifications based on your suggestion @windsonsea

@windsonsea
Copy link
Member

Note this page is refactoring in #41540.

@windsonsea
Copy link
Member

#41540 is merged. Could you please include those changes too? @bzsuni

@tengqm
Copy link
Contributor

tengqm commented Jun 21, 2023

Looks like this has no conflict with the 'main' branch?

@windsonsea
Copy link
Member

windsonsea commented Jul 6, 2023 •
edited
Loading

Yes, no conflict. This file is frequently changed recently more than 1000 lines and similar zh PR #41902 is opened too.

Merging this can move a step forward, IMO.

@asa3311 asa3311 mentioned this pull request Jul 6, 2023
Merged
@tengqm
Copy link
Contributor

tengqm commented Jul 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@windsonsea
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ed98cd0b651e0fb5bb3b8464f7c88d6a04ddbfb

@k8s-ci-robot k8s-ci-robot merged commit 84728c6 into kubernetes:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@Sea-n Sea-n Awaiting requested review from Sea-n

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzsuni @windsonsea @tengqm @k8s-ci-robot