Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added .editorconfig #42396

Merged
merged 2 commits into from
Aug 9, 2023
Merged

added .editorconfig #42396

merged 2 commits into from
Aug 9, 2023

Conversation

Karthik-PM
Copy link
Contributor

@Karthik-PM Karthik-PM commented Aug 5, 2023 •
edited
Loading

Contributes to #37679

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Aug 5, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 5, 2023
@Karthik-PM Karthik-PM mentioned this pull request Aug 5, 2023
Closed
@netlify
Copy link

netlify bot commented Aug 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 29178c6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64d128db32de7a0008d3264f
😎 Deploy Preview https://deploy-preview-42396--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Karthik-PM
Karthik-PM commented Aug 7, 2023
View reviewed changes
Copy link
Contributor Author

@Karthik-PM Karthik-PM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added the change @divya-mohan0209

divya-mohan0209
divya-mohan0209 reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4406e97bf7161c6986d76c811d3ef8657cc90855

@windsonsea
Copy link
Member

/lgtm

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 02f34df into kubernetes:main Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@sftim sftim Awaiting requested review from sftim

Assignees

@divya-mohan0209 divya-mohan0209

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Karthik-PM @k8s-ci-robot @windsonsea @natalisucks @divya-mohan0209