Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove archived third-party client library #43960

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

steve-hardman
Copy link
Contributor

Removed third-party lib https://github.com/ericchiang/k8s as requested in issue #43951

This will fix #43951

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 16, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
Copy link

netlify bot commented Nov 16, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d24f8bb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655aa3c92e0f430008b62ee3
😎 Deploy Preview https://deploy-preview-43960--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Nov 16, 2023

/approve
Please fix the nit.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c5052ad9577a81617fcd6949969c1d313267cbe

@dipesh-rawat
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 20, 2023
@dipesh-rawat
Copy link
Member

OK to unhold once https://github.com/kubernetes/website/pull/43960/files#r1395013437 is addressed.

/unhold

Review comment addressed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit e4f8dab into kubernetes:main Nov 20, 2023
6 checks passed
uos-ljtian added a commit to uos-ljtian/website that referenced this pull request Nov 20, 2023
Remove archived lib. 
Synchronization information.
Source kubernetes#43960
tamilselvan1102 pushed a commit to tamilselvan1102/website that referenced this pull request Nov 24, 2023
* Remove archived lib

* Remove archived lib

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>

---------

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
tamilselvan1102 pushed a commit to tamilselvan1102/website that referenced this pull request Nov 24, 2023
Remove archived lib. 
Synchronization information.
Source kubernetes#43960
@steve-hardman steve-hardman deleted the remove-client-lib branch February 25, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Libraries: github.com/ericchiang/k8s listed but unmaintained since 3-5 years.
5 participants