Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in kubeadm-config v1beta4 config reference #45709

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix typo in kubeadm-config v1beta4 config reference #45709

merged 1 commit into from
Mar 27, 2024

Conversation

stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Mar 27, 2024 •
edited
Loading

When adding formatting to the controlPlaneEndpoint config reference for kubeadm-config v1beta4 it appears the first letter of the value was accidentally dropped. This adds it back in the two places where this happened.

My guess is adding the "c" in the <code> block in 7451649 accidentally picked up the leading "c" from the name.

Closes: #45602

@stmcginnis
Fix typo in kubeadm-config v1beta4 config reference
cc0785e 
When adding formatting to the controlPlaneEndpoint config reference for
kubeadm-config v1beta4 it appears the first letter of the value was accidentally
dropped. This adds it back in the two places where this happened.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 27, 2024
@stmcginnis stmcginnis mentioned this pull request Mar 27, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cc0785e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66042f34c7320a0009969be2
😎 Deploy Preview https://deploy-preview-45709--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

neolit123
neolit123 reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @tengqm
#45602 (comment)

v1beta4 is WIP and not enabled in code.
it's there in the folder but kubeadm will throw an error if it's used.

@stmcginnis @tengqm can we put a note about that on top of this MD?
also would this note be auto-removed when the MD is generated on next release when v1beta4 is actually active?

@neolit123
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 27, 2024
@tengqm
Copy link
Contributor

tengqm commented Mar 27, 2024

/lgtm
/approve

This was a typo introduced by me. The source used for reference generation wasn't from k8s.io/kubernetes/cmd/kubeadm package, because k8s.io/kubernetes cannot be imported as a module from an external project. The generator uses a manually copy-pasted version at github.com/tengqm/kubeconfig project.

I have fixed the kubeadm type definition source code. This one can be safely kicked in.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ddd6055e4fc92e23eae0bc6b1167b5b117004f2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit cd5e6b8 into kubernetes:main Mar 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in auto-generated "kubeadm Configuration (v1beta4)" reference page
4 participants
@stmcginnis @neolit123 @tengqm @k8s-ci-robot