Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention container environment variables in concepts/pods #45774

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented Apr 4, 2024

Mention container environment variables in concepts/workloads/pods. Fixes #45405

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5270c7a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66104b41c24e7f0008520f2f
😎 Deploy Preview https://deploy-preview-45774--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 170 to 172
When you create a Pod, you can include·¬
[environment variables](/docs/tasks/inject-data-application/define-environment-variable-container/)·¬
in the Pod template for the containers that run in the Pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few stray characters ".¬" that seem unintentional and might need to be removed.

Suggested change
When you create a Pod, you can include·¬
[environment variables](/docs/tasks/inject-data-application/define-environment-variable-container/)·¬
in the Pod template for the containers that run in the Pod.
When you create a Pod, you can include
[environment variables](/docs/tasks/inject-data-application/define-environment-variable-container/)
in the Pod template for the containers that run in the Pod.

Mention container environment variables in pods
@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03c2f03283e641e8ae53fb1c4c48a99e60be3a0a

@k8s-ci-robot k8s-ci-robot merged commit dbf8353 into kubernetes:main Apr 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention environment variables in Pod concept
5 participants